-
-
Notifications
You must be signed in to change notification settings - Fork 222
Remove traceparent
propagation (per default)
#4185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
traceparent
propagationtraceparent
propagation (per default)
cc @hangy since I pinged on a merged PR |
Looks like he's OK for us just to remove that... it's a pity 😞 |
FWIW I don't use it, as I implemented the issue/feature for other people that might need it. Since we can't know if anyone else depends on it, it's still a breaking change |
Thanks for the reply and more context. And sorry for the confusion we've caused. We should have closed the original issue earlier.
|
I think the goal is to get rid of it by the next major version, at the latest. It's been out in the wild for about a week so I think we're probably pretty safe to just remove it. If anyone complains, then we can add it back as an OptIn and decide how we want to do that based on why folks want it back. |
Kinda a bummer 😔 Seems like there should be some ways to allow traceparent inheritance from an allowlist, or other ways of avoiding this "external services sending trace data" issue |
Hm, I'm not sure this is something we can unilaterally decide to support in just the .NET SDK. @cleptric do you have a bit more context around this that we can share with @ericsampson ? |
@ericsampson what is the scenario where you would need/want to propagate trace context either to Sentry or from Sentry using the traceparent header? |
We no longer want to support @jamescrosswell @Flash0ver for now, please get the PR that reverts this out in due time 🙏 |
Uh oh!
There was an error while loading. Please reload this page.
Support for W3C
traceparent
header is removed again from other SDKs, too.It seems to do more harm than good: https://blog.thms.uk/2025/05/openai-sucks
See also getsentry/sentry-docs#13686
I don't think we added any .NET specific docs yet
Was originally added via #4084
Was initially published in Sentry 5.6.0
Alternatively, we could make this an explicit opt-in instead, where the default is disabled.
The text was updated successfully, but these errors were encountered: