Skip to content

Commit 1b0b536

Browse files
authored
fix: stack-trace in_app false being omitted (#647)
1 parent 02e712a commit 1b0b536

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
### Bug fixes
6+
7+
- Fix frames recognized as not being in-app still showing as in-app ([#647](https://github.com/getsentry/sentry-go/pull/647))
8+
39
## 0.21.0
410

511
The Sentry SDK team is happy to announce the immediate availability of Sentry Go SDK v0.21.0.

stacktrace.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ type Frame struct {
174174
PreContext []string `json:"pre_context,omitempty"`
175175
ContextLine string `json:"context_line,omitempty"`
176176
PostContext []string `json:"post_context,omitempty"`
177-
InApp bool `json:"in_app,omitempty"`
177+
InApp bool `json:"in_app"`
178178
Vars map[string]interface{} `json:"vars,omitempty"`
179179
// Package and the below are not used for Go stack trace frames. In
180180
// other platforms it refers to a container where the Module can be

stacktrace_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,7 @@ func TestEventWithExceptionStacktraceMarshalJSON(t *testing.T) {
230230
`"vars":{"fooint":25,"foostr":"bar"}` +
231231
`},{` +
232232
`"symbol":"nativesym",` +
233+
`"in_app":false,` +
233234
`"package":"my.dylib",` +
234235
`"instruction_addr":"0xabcd0010",` +
235236
`"addr_mode":"abs",` +

0 commit comments

Comments
 (0)