Skip to content

Commit 05c34af

Browse files
committed
more CI tuning
1 parent 8b5a7fa commit 05c34af

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

packages/replay/metrics/configs/ci/collect.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ const result = await collector.execute({
2727
tries: 10,
2828
async shouldAccept(results: Metrics[]): Promise<boolean> {
2929
const stats = new MetricsStats(results);
30-
printStats(stats);
30+
await printStats(stats);
3131

32-
if (!checkStdDev(stats, 'lcp', MetricsStats.lcp, 30)
32+
if (!checkStdDev(stats, 'lcp', MetricsStats.lcp, 50)
3333
|| !checkStdDev(stats, 'cls', MetricsStats.cls, 0.1)
3434
|| !checkStdDev(stats, 'cpu', MetricsStats.cpu, 1)
3535
|| !checkStdDev(stats, 'memory-mean', MetricsStats.memoryMean, 1000 * 1024)

packages/replay/metrics/src/collector.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,9 @@ export class MetricsCollector {
7777
} catch (e) {
7878
console.warn(`${innerLabel} failed with ${e}`);
7979
break;
80+
} finally {
81+
console.timeEnd(innerLabel);
8082
}
81-
console.timeEnd(innerLabel);
8283
}
8384
console.timeEnd(label);
8485
if ((results.length == testCase.runs) && await testCase.shouldAccept(results)) {

packages/replay/metrics/test-apps/jank/app.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ document.addEventListener("DOMContentLoaded", function() {
2525
incrementor = 10,
2626
distance = 3,
2727
frame,
28-
minimum = 70,
28+
minimum = 30,
2929
subtract = document.querySelector('.subtract'),
3030
add = document.querySelector('.add');
3131

0 commit comments

Comments
 (0)