reorganize test script and fix transformer use in node 8

Author: lobsterkatie

scripts/test.ts

@@ -1,66 +1,127 @@
-import { spawnSync } from 'child_process';
-import { join } from 'path';
+import * as childProcess from 'child_process';
+import * as fs from 'fs';
+import * as path from 'path';
 
-function run(cmd: string, cwd: string = '') {
-  const result = spawnSync(cmd, { shell: true, stdio: 'inherit', cwd: join(__dirname, '..', cwd || '') });
+const CURRENT_NODE_VERSION = process.version.replace('v', '').split('.')[0];
 
-  if (result.status !== 0) {
-    process.exit(result.status || undefined);
-  }
-}
+// We run ember tests in their own job.
+const DEFAULT_SKIP_TESTS_PACKAGES = ['@sentry/ember'];
+// These packages don't support Node 8 for syntax or dependency reasons.
+const NODE_8_SKIP_TESTS_PACKAGES = [
+  ...DEFAULT_SKIP_TESTS_PACKAGES,
+  '@sentry-internal/eslint-plugin-sdk',
+  '@sentry/react',
+  '@sentry/wasm',
+  '@sentry/gatsby',
+  '@sentry/serverless',
+  '@sentry/nextjs',
+  '@sentry/angular',
+];
 
-const nodeMajorVersion = parseInt(process.version.split('.')[0].replace('v', ''), 10);
+// We have to downgrade some of our dependencies in order to run tests in Node 8 and 10.
+const NODE_8_LEGACY_DEPENDENCIES = [
+  '[email protected]',
+  '[email protected]',
+  '[email protected]',
+  '[email protected]',
+  '[email protected]',
+];
+const NODE_10_LEGACY_DEPENDENCIES = ['[email protected]'];
 
-// Ember tests require dependency changes for each set of tests, making them quite slow. To compensate for this, in CI
-// we run them in a separate, parallel job.
-let ignorePackages = ['@sentry/ember'];
+/**
+ * Run the given shell command, piping the shell process's `stdin`, `stdout`, and `stderr` to that of the current
+ * process. Returns contents of `stdout`.
+ */
+function run(cmd: string, options?: childProcess.ExecSyncOptions) {
+  return childProcess.execSync(cmd, { stdio: 'inherit', ...options });
+}
 
-// install legacy versions of third-party packages whose current versions don't support node 8 or 10, and skip testing
-// our own packages which don't support node 8 for various syntax or dependency reasons
-if (nodeMajorVersion <= 10) {
-  let legacyDependencies;
+/**
+ * Install the given legacy dependencies, for compatibility with tests run in older versions of Node.
+ */
+function installLegacyDeps(legacyDeps: string[] = []): void {
+  // Ignoring engines and scripts lets us get away with having incompatible things installed for SDK packages we're not
+  // testing in the current node version, and ignoring the root check lets us install things at the repo root.
+  run(`yarn add --dev --ignore-engines --ignore-scripts --ignore-workspace-root-check ${legacyDeps.join(' ')}`);
+}
 
-  if (nodeMajorVersion === 8) {
-    legacyDependencies = [
-      '[email protected]',
-      '[email protected]',
-      '[email protected]',
-      '[email protected]',
-      '[email protected]',
-    ];
+/**
+ * Add a tranformer to our jest config, to do the same `const`-to-`var` replacement as our rollup plugin does.
+ *
+ * This is needed because Node 8 doesn't like the way we shadow `global` (`const global = getGlobalObject()`). Changing
+ * it to a `var` solves this by making it redeclarable.
+ *
+ */
+function addTransformer(): void {
+  // Though newer ts-jest versions support TS transformers, the legacy version does not.
+  run('yarn tsc --skipLibCheck jest/transformers/constReplacer.ts');
 
-    ignorePackages = [
-      ...ignorePackages,
-      '@sentry-internal/eslint-plugin-sdk',
-      '@sentry/react',
-      '@sentry/wasm',
-      '@sentry/gatsby',
-      '@sentry/serverless',
-      '@sentry/nextjs',
-      '@sentry/angular',
-    ];
+  // Loading the existing Jest config will error out unless the config file has an accompanying types file, so we have
+  // to create that before we can load it.
+  run('yarn tsc --allowJs --skipLibCheck --declaration --emitDeclarationOnly jest/jest.config.js');
+  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  const jestConfig = require('../jest/jest.config.js');
 
-    // This is a hack, to deal the fact that the browser-based tests fail under Node 8, because of a conflict buried
-    // somewhere in the interaction between our current overall set of dependencies and the older versions of a small
-    // subset we're about to install below. Since they're browser-based, these tests are never going to be running in a
-    // node 8 environment in any case, so it's fine to skip them here. (In the long run, we should only run such tests
-    // against a single version of node, but in the short run, this at least allows us to not be blocked by the
-    // failures.)
-    run('rm -rf packages/tracing/test/browser');
-  }
-  // Node 10
-  else {
-    legacyDependencies = ['[email protected]'];
-  }
+  // Inject the transformer
+  jestConfig.globals['ts-jest'].astTransformers = ['<rootDir>/../../jest/transformers/constReplacer.js'];
 
-  const legacyDepStr = legacyDependencies.join(' ');
+  // When we required the jest config file above, all expressions it contained were evaluated. Specifically, the
+  //     `rootDir: process.cwd()`
+  // entry was replaced with
+  //     `rootDir: "<hard-coded string result of running `process.cwd()` in the current process>"`,
+  // Though it's a little brute-force-y, the easiest way to fix this is to just stringify the code and perform the
+  // substitution in reverse.
+  const stringifiedConfig = JSON.stringify(jestConfig, null, 2).replace(
+    `"rootDir": "${process.cwd()}"`,
+    'rootDir: process.cwd()',
+  );
 
-  // ignoring engines and scripts lets us get away with having incompatible things installed for packages we're not testing
-  run(`yarn add --dev --ignore-engines --ignore-scripts --ignore-workspace-root-check ${legacyDepStr}`);
+  // Now we just have to convert it back to a module and write it to disk
+  const code = `module.exports = ${stringifiedConfig}`;
+  fs.writeFileSync(path.resolve('jest/jest.config.js'), code);
 }
 
-const ignoreFlags = ignorePackages.map(dep => `--ignore="${dep}"`).join(' ');
+/**
+ * Skip tests which don't apply to Node than therefore don't need to run in older Node versions.
+ *
+ * TODO We're foreced to skip these tests for compatibility reasons (right now this function only gets called in Node
+ * 8), but we could be skipping a lot more tests in Node 8-14 - anything where compatibility with different Node
+ * versions is irrelevant - and only running them in Node 16.
+ */
+function skipNonNodeTests(): void {
+  run('rm -rf packages/tracing/test/browser');
+}
 
-run(`yarn test ${ignoreFlags}`);
+/**
+ * Run tests, ignoring the given packages
+ */
+function runWithIgnores(skipPackages: string[] = []): void {
+  const ignoreFlags = skipPackages.map(dep => `--ignore="${dep}"`).join(' ');
+  run(`yarn test ${ignoreFlags}`);
+}
+
+/**
+ * Run the tests, accounting for compatibility problems in older versions of Node.
+ */
+function runTests(): void {
+  if (CURRENT_NODE_VERSION === '8') {
+    installLegacyDeps(NODE_8_LEGACY_DEPENDENCIES);
+    // Inject a `const`-to-`var` transformer, in order to stop Node 8 from complaining when we shadow `global`
+    addTransformer();
+    // TODO Right now, this just skips incompatible tests, but it could be skipping more (hence the aspirational name),
+    // and not just in Node 8. See `skipNonNodeTests`'s docstring.
+    skipNonNodeTests();
+    runWithIgnores(NODE_8_SKIP_TESTS_PACKAGES);
+  }
+  //
+  else if (CURRENT_NODE_VERSION === '10') {
+    installLegacyDeps(NODE_10_LEGACY_DEPENDENCIES);
+    runWithIgnores(DEFAULT_SKIP_TESTS_PACKAGES);
+  }
+  //
+  else {
+    runWithIgnores(DEFAULT_SKIP_TESTS_PACKAGES);
+  }
+}
 
-process.exit(0);
+runTests();