feat(node): Add maxIncomingRequestBodySize (#16225)

Adds `maxIncomingRequestBodySize` to the Node `httpIntegration`.
The setting controls the maximum size of HTTP request bodies attached to
events.

There is the option `maxRequestBodySize`
([docs](https://develop.sentry.dev/sdk/expected-features/#attaching-request-body-in-server-sdks))
in other SDKs, but to be more specific, this is named with `incoming`.

Available options:
- 'none': No request bodies will be attached
- 'small': Request bodies up to 1,000 bytes will be attached
- 'medium': Request bodies up to 10,000 bytes will be attached (default)
- 'always': Request bodies will always be attached (up to 1 MB)

closes #16179

Author: s1gr1d

dev-packages/node-integration-tests/suites/express/with-http/instrument.mjs renamed to dev-packages/node-integration-tests/suites/express/with-http/base/instrument.mjs

@@ -1,5 +1,5 @@
 import { afterAll, describe } from 'vitest';
-import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';
+import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../../utils/runner';
 
 describe('express with http import', () => {
   afterAll(() => {

dev-packages/node-integration-tests/suites/express/with-http/scenario.mjs renamed to dev-packages/node-integration-tests/suites/express/with-http/base/scenario.mjs

@@ -0,0 +1,35 @@
+// Payload for requests
+export function generatePayload(sizeInBytes: number): { data: string } {
+  const baseSize = JSON.stringify({ data: '' }).length;
+  const contentLength = sizeInBytes - baseSize;
+
+  return { data: 'x'.repeat(contentLength) };
+}
+
+// Generate the "expected" body string
+export function generatePayloadString(dataLength: number, truncate?: boolean): string {
+  const prefix = '{"data":"';
+  const suffix = truncate ? '...' : '"}';
+
+  const baseStructuralLength = prefix.length + suffix.length;
+  const dataContent = 'x'.repeat(dataLength - baseStructuralLength);
+
+  return `${prefix}${dataContent}${suffix}`;
+}
+
+// Functions for non-ASCII payloads (e.g. emojis)
+export function generateEmojiPayload(sizeInBytes: number): { data: string } {
+  const baseSize = JSON.stringify({ data: '' }).length;
+  const contentLength = sizeInBytes - baseSize;
+
+  return { data: '👍'.repeat(contentLength) };
+}
+export function generateEmojiPayloadString(dataLength: number, truncate?: boolean): string {
+  const prefix = '{"data":"';
+  const suffix = truncate ? '...' : '"}';
+
+  const baseStructuralLength = suffix.length;
+  const dataContent = '👍'.repeat(dataLength - baseStructuralLength);
+
+  return `${prefix}${dataContent}${suffix}`;
+}

dev-packages/node-integration-tests/suites/express/with-http/test.ts renamed to dev-packages/node-integration-tests/suites/express/with-http/base/test.ts

@@ -0,0 +1,10 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  release: '1.0',
+  tracesSampleRate: 1.0,
+  transport: loggingTransport,
+  integrations: [Sentry.httpIntegration({ maxIncomingRequestBodySize: 'always' })],
+});

dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/generatePayload.ts

@@ -0,0 +1,9 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  release: '1.0',
+  tracesSampleRate: 1.0,
+  transport: loggingTransport,
+});

dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-always.mjs

@@ -0,0 +1,10 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  release: '1.0',
+  tracesSampleRate: 1.0,
+  transport: loggingTransport,
+  integrations: [Sentry.httpIntegration({ maxIncomingRequestBodySize: 'medium' })],
+});

dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-default.mjs

@@ -0,0 +1,15 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  release: '1.0',
+  tracesSampleRate: 1.0,
+  transport: loggingTransport,
+  integrations: [
+    Sentry.httpIntegration({
+      maxIncomingRequestBodySize: 'none',
+      ignoreIncomingRequestBody: url => url.includes('/ignore-request-body'),
+    }),
+  ],
+});

dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-medium.mjs

@@ -0,0 +1,10 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  release: '1.0',
+  tracesSampleRate: 1.0,
+  transport: loggingTransport,
+  integrations: [Sentry.httpIntegration({ maxIncomingRequestBodySize: 'small' })],
+});

dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-none.mjs

@@ -0,0 +1,32 @@
+import * as Sentry from '@sentry/node';
+import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
+import bodyParser from 'body-parser';
+import express from 'express';
+
+const app = express();
+
+// Increase limit for JSON parsing
+app.use(bodyParser.json({ limit: '3mb' }));
+app.use(express.json({ limit: '3mb' }));
+
+app.post('/test-body-size', (req, res) => {
+  const receivedSize = JSON.stringify(req.body).length;
+  res.json({
+    success: true,
+    receivedSize,
+    message: 'Payload processed successfully',
+  });
+});
+
+app.post('/ignore-request-body', (req, res) => {
+  const receivedSize = JSON.stringify(req.body).length;
+  res.json({
+    success: true,
+    receivedSize,
+    message: 'Payload processed successfully',
+  });
+});
+
+Sentry.setupExpressErrorHandler(app);
+
+startExpressServerAndSendPortToRunner(app);