Skip to content

Commit 1a89631

Browse files
committed
feat: Disable client once flushed (#1904)
1 parent 7e081b5 commit 1a89631

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ since we removed some methods from the public API and removed some classes from
1515
- **breaking** [core] ref: Use `SyncPromise` internally, this reduces memory pressure by a lot.
1616
- **breaking** [browser] ref: Removed `BrowserBackend` from default export.
1717
- **breaking** [node] ref: Removed `BrowserBackend` from default export.
18+
- **breaking** [core] feat: Disable client once flushed using `close` method
1819
- ref: Move internal `ExtendedError` to a types package
1920
- **breaking** [core] ref: Pass `Event` to `sendEvent` instead of already stringified data
2021
- [utils] feat: Introduce `isSyntheticEvent` util

packages/core/src/baseclient.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,9 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
333333
* @inheritDoc
334334
*/
335335
public async close(timeout?: number): Promise<boolean> {
336-
return this.flush(timeout);
336+
return this.flush(timeout).finally(() => {
337+
this.getOptions().enabled = false;
338+
});
337339
}
338340

339341
/**

0 commit comments

Comments
 (0)