Commit 1d64a06
authored
fix(browser): Add replay and profiling options to
Add missing replay and profiling options to the
`BrowserClientOptions` interface. Previously, we only exposed these
types to `BrowserOptions`. This led to type errors for users who
directly create a client, without using `Sentry.init` (as reported in
#8857).
While one would think that `BrowserClientOptions` is basically a
superset of `BrowserOptions` (leaving aside `stackparser`,
`integrations` and `transport`) this is in fact not the case, which IMO
is the core problem here. `BrowserClientOptions` only inherits the base
`Options` (which are shared between browser and node), in addition to
transport options. However, changing this so that,
`BrowserClientOptions` inherits from `BrowserOptions` is a breaking
change, so I opted to just add the missing options to
`BrowserClientOptions`.BrowserClientOptions (#8921)1 parent 5fdaaa7 commit 1d64a06
1 file changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
0 commit comments