Skip to content

Commit 312aab0

Browse files
committed
metrics collection timeout
1 parent 9c5c5ea commit 312aab0

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

packages/replay/metrics/configs/ci/collect.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Metrics, MetricsCollector } from '../../src/collector.js';
22
import { JankTestScenario } from '../../src/scenarios.js';
33
import { latestResultFile } from './env.js';
44

5-
const collector = new MetricsCollector();
5+
const collector = new MetricsCollector({ headless: true });
66
const result = await collector.execute({
77
name: 'dummy',
88
a: new JankTestScenario(false),

packages/replay/metrics/src/collector.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,20 @@ export class Metrics {
2323
}
2424
}
2525

26+
export interface MetricsCollectorOptions {
27+
headless: boolean;
28+
}
2629

2730
export class MetricsCollector {
31+
private options: MetricsCollectorOptions;
32+
33+
constructor(options: Partial<MetricsCollectorOptions>) {
34+
this.options = {
35+
headless: false,
36+
...options
37+
};
38+
}
39+
2840
public async execute(testCase: TestCase): Promise<Result> {
2941
console.log(`Executing test case ${testCase.name}`);
3042
console.group();
@@ -64,7 +76,7 @@ export class MetricsCollector {
6476
const disposeCallbacks: (() => Promise<void>)[] = [];
6577
try {
6678
const browser = await puppeteer.launch({
67-
headless: false,
79+
headless: this.options.headless,
6880
});
6981
disposeCallbacks.push(async () => browser.close());
7082
const page = await browser.newPage();

0 commit comments

Comments
 (0)