rename tests & add breadcrumb tests

Author: mydea

packages/integration-tests/suites/integrations/Breadcrumbs/fetch/get/subject.js

@@ -0,0 +1,5 @@
+const xhr = new XMLHttpRequest();
+
+fetch('http://localhost:7654/foo').then(() => {
+  Sentry.captureException('test error');
+});

packages/integration-tests/suites/integrations/ExtendedNetworkBreadcrumbs/fetch/get/test.ts renamed to packages/integration-tests/suites/integrations/Breadcrumbs/fetch/get/test.ts

@@ -4,7 +4,7 @@ import type { Event } from '@sentry/types';
 import { sentryTest } from '../../../../../utils/fixtures';
 import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
 
-sentryTest('adds a breadcrumb for basic fetch GET request', async ({ getLocalTestPath, page }) => {
+sentryTest('captures Breadcrumb for basic GET request', async ({ getLocalTestPath, page }) => {
   const url = await getLocalTestPath({ testDir: __dirname });
 
   await page.route('**/foo', route => {
@@ -30,7 +30,6 @@ sentryTest('adds a breadcrumb for basic fetch GET request', async ({ getLocalTes
     type: 'http',
     data: {
       method: 'GET',
-      response_body_size: 29,
       status_code: 200,
       url: 'http://localhost:7654/foo',
     },

packages/integration-tests/suites/integrations/Breadcrumbs/fetch/init.js

@@ -0,0 +1,10 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  defaultIntegrations: false,
+  integrations: [new Sentry.Integrations.Breadcrumbs()],
+  sampleRate: 1,
+});

packages/integration-tests/suites/integrations/Breadcrumbs/fetch/post/subject.js

@@ -0,0 +1,13 @@
+const xhr = new XMLHttpRequest();
+
+fetch('http://localhost:7654/foo', {
+  method: 'POST',
+  body: '{"my":"body"}',
+  headers: {
+    Accept: 'application/json',
+    'Content-Type': 'application/json',
+    Cache: 'no-cache',
+  },
+}).then(() => {
+  Sentry.captureException('test error');
+});

packages/integration-tests/suites/integrations/Breadcrumbs/fetch/post/test.ts

@@ -0,0 +1,37 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
+
+sentryTest('captures Breadcrumb for POST request', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  await page.route('**/foo', route => {
+    return route.fulfill({
+      status: 200,
+      body: JSON.stringify({
+        userNames: ['John', 'Jane'],
+      }),
+      headers: {
+        'Content-Type': 'application/json',
+      },
+    });
+  });
+
+  const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+
+  expect(eventData.exception?.values).toHaveLength(1);
+
+  expect(eventData?.breadcrumbs?.length).toBe(1);
+  expect(eventData!.breadcrumbs![0]).toEqual({
+    timestamp: expect.any(Number),
+    category: 'fetch',
+    type: 'http',
+    data: {
+      method: 'POST',
+      status_code: 200,
+      url: 'http://localhost:7654/foo',
+    },
+  });
+});

packages/integration-tests/suites/integrations/Breadcrumbs/xhr/get/subject.js

@@ -0,0 +1,10 @@
+const xhr = new XMLHttpRequest();
+
+xhr.open('GET', 'http://localhost:7654/foo');
+xhr.send();
+
+xhr.addEventListener('readystatechange', function () {
+  if (xhr.readyState === 4) {
+    Sentry.captureException('test error');
+  }
+});

packages/integration-tests/suites/integrations/ExtendedNetworkBreadcrumbs/xhr/get/test.ts renamed to packages/integration-tests/suites/integrations/Breadcrumbs/xhr/get/test.ts

@@ -4,7 +4,7 @@ import type { Event } from '@sentry/types';
 import { sentryTest } from '../../../../../utils/fixtures';
 import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
 
-sentryTest('adds a breadcrumb for basic XHR GET request', async ({ getLocalTestPath, page }) => {
+sentryTest('captures Breadcrumb for basic GET request', async ({ getLocalTestPath, page }) => {
   const url = await getLocalTestPath({ testDir: __dirname });
 
   await page.route('**/foo', route => {
@@ -15,6 +15,7 @@ sentryTest('adds a breadcrumb for basic XHR GET request', async ({ getLocalTestP
       }),
       headers: {
         'Content-Type': 'application/json',
+        'Content-Length': '',
       },
     });
   });
@@ -30,7 +31,6 @@ sentryTest('adds a breadcrumb for basic XHR GET request', async ({ getLocalTestP
     type: 'http',
     data: {
       method: 'GET',
-      response_body_size: 29,
       status_code: 200,
       url: 'http://localhost:7654/foo',
     },

packages/integration-tests/suites/integrations/Breadcrumbs/xhr/init.js

@@ -0,0 +1,10 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  defaultIntegrations: false,
+  integrations: [new Sentry.Integrations.Breadcrumbs()],
+  sampleRate: 1,
+});

packages/integration-tests/suites/integrations/Breadcrumbs/xhr/post/subject.js

@@ -0,0 +1,12 @@
+const xhr = new XMLHttpRequest();
+
+xhr.open('POST', 'http://localhost:7654/foo');
+xhr.setRequestHeader('Accept', 'application/json');
+xhr.setRequestHeader('Content-Type', 'application/json');
+xhr.send('{"my":"body"}');
+
+xhr.addEventListener('readystatechange', function () {
+  if (xhr.readyState === 4) {
+    Sentry.captureException('test error');
+  }
+});

packages/integration-tests/suites/integrations/Breadcrumbs/xhr/post/test.ts

@@ -0,0 +1,37 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
+
+sentryTest('captures Breadcrumb for POST request', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  await page.route('**/foo', route => {
+    return route.fulfill({
+      status: 200,
+      body: JSON.stringify({
+        userNames: ['John', 'Jane'],
+      }),
+      headers: {
+        'Content-Type': 'application/json',
+      },
+    });
+  });
+
+  const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+
+  expect(eventData.exception?.values).toHaveLength(1);
+
+  expect(eventData?.breadcrumbs?.length).toBe(1);
+  expect(eventData!.breadcrumbs![0]).toEqual({
+    timestamp: expect.any(Number),
+    category: 'xhr',
+    type: 'http',
+    data: {
+      method: 'POST',
+      status_code: 200,
+      url: 'http://localhost:7654/foo',
+    },
+  });
+});

packages/integration-tests/suites/integrations/ExtendedNetworkBreadcrumbs/fetch/get/subject.js renamed to packages/integration-tests/suites/integrations/ExtendedNetworkBreadcrumbs/fetch/noContentLengthHeader/subject.js

@@ -4,7 +4,7 @@ import type { Event } from '@sentry/types';
 import { sentryTest } from '../../../../../utils/fixtures';
 import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
 
-sentryTest('adds a breadcrumb for basic fetch POST request', async ({ getLocalTestPath, page }) => {
+sentryTest('does not capture response_body_size without Content-Length header', async ({ getLocalTestPath, page }) => {
   const url = await getLocalTestPath({ testDir: __dirname });
 
   await page.route('**/foo', route => {
@@ -30,9 +30,7 @@ sentryTest('adds a breadcrumb for basic fetch POST request', async ({ getLocalTe
     category: 'fetch',
     type: 'http',
     data: {
-      method: 'POST',
-      request_body_size: 13,
-      // No response_body_size without Content-Length header!
+      method: 'GET',
       status_code: 200,
       url: 'http://localhost:7654/foo',
     },

packages/integration-tests/suites/integrations/ExtendedNetworkBreadcrumbs/fetch/post/test.ts renamed to packages/integration-tests/suites/integrations/ExtendedNetworkBreadcrumbs/fetch/noContentLengthHeader/test.ts

@@ -0,0 +1,28 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
+
+sentryTest('captures request_body_size when body is sent', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  await page.route('**/foo', route => {
+    return route.fulfill({
+      status: 200,
+      body: JSON.stringify({
+        userNames: ['John', 'Jane'],
+      }),
+      headers: {
+        'Content-Type': 'application/json',
+      },
+    });
+  });
+
+  const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+
+  expect(eventData.exception?.values).toHaveLength(1);
+
+  expect(eventData?.breadcrumbs?.length).toBe(1);
+  expect(eventData!.breadcrumbs![0].data!.request_body_size).toEqual(13);
+});

packages/integration-tests/suites/integrations/ExtendedNetworkBreadcrumbs/fetch/post/subject.js renamed to packages/integration-tests/suites/integrations/ExtendedNetworkBreadcrumbs/fetch/requestBody/subject.js

@@ -4,7 +4,7 @@ import type { Event } from '@sentry/types';
 import { sentryTest } from '../../../../../utils/fixtures';
 import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
 
-sentryTest('adds a breadcrumb for basic XHR POST request', async ({ getLocalTestPath, page }) => {
+sentryTest('captures response_body_size without Content-Length header', async ({ getLocalTestPath, page }) => {
   const url = await getLocalTestPath({ testDir: __dirname });
 
   await page.route('**/foo', route => {
@@ -30,8 +30,7 @@ sentryTest('adds a breadcrumb for basic XHR POST request', async ({ getLocalTest
     category: 'xhr',
     type: 'http',
     data: {
-      method: 'POST',
-      request_body_size: 13,
+      method: 'GET',
       response_body_size: 29,
       status_code: 200,
       url: 'http://localhost:7654/foo',

packages/integration-tests/suites/integrations/ExtendedNetworkBreadcrumbs/fetch/requestBody/test.ts

@@ -0,0 +1,29 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
+
+sentryTest('captures request_body_size when body is sent', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  await page.route('**/foo', route => {
+    return route.fulfill({
+      status: 200,
+      body: JSON.stringify({
+        userNames: ['John', 'Jane'],
+      }),
+      headers: {
+        'Content-Type': 'application/json',
+        'Content-Length': '',
+      },
+    });
+  });
+
+  const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+
+  expect(eventData.exception?.values).toHaveLength(1);
+
+  expect(eventData?.breadcrumbs?.length).toBe(1);
+  expect(eventData!.breadcrumbs![0].data!.request_body_size).toEqual(13);
+});