ref(replay): Hide internal request tracing behind experiments flag

Author: mydea

packages/replay/src/coreHandlers/handleFetch.ts

@@ -1,7 +1,7 @@
 import type { ReplayPerformanceEntry } from '../createPerformanceEntry';
 import type { ReplayContainer } from '../types';
 import { createPerformanceSpans } from '../util/createPerformanceSpans';
-import { isIngestHost } from '../util/isIngestHost';
+import { shouldFilterRequest } from '../util/shouldFilterRequest';
 
 interface FetchHandlerData {
   args: Parameters<typeof fetch>;
@@ -28,11 +28,6 @@ export function handleFetch(handlerData: FetchHandlerData): null | ReplayPerform
 
   const { startTimestamp, endTimestamp, fetchData, response } = handlerData;
 
-  // Do not capture fetches to Sentry ingestion endpoint
-  if (isIngestHost(fetchData.url)) {
-    return null;
-  }
-
   return {
     type: 'resource.fetch',
     start: startTimestamp / 1000,
@@ -60,6 +55,10 @@ export function handleFetchSpanListener(replay: ReplayContainer): (handlerData:
       return;
     }
 
+    if (shouldFilterRequest(replay, result.name)) {
+      return;
+    }
+
     replay.addUpdate(() => {
       createPerformanceSpans(replay, [result]);
       // Returning true will cause `addUpdate` to not flush

packages/replay/src/coreHandlers/handleXhr.ts

@@ -1,7 +1,7 @@
 import { ReplayPerformanceEntry } from '../createPerformanceEntry';
 import type { ReplayContainer } from '../types';
 import { createPerformanceSpans } from '../util/createPerformanceSpans';
-import { isIngestHost } from '../util/isIngestHost';
+import { shouldFilterRequest } from '../util/shouldFilterRequest';
 
 // From sentry-javascript
 // e.g. https://github.com/getsentry/sentry-javascript/blob/c7fc025bf9fa8c073fdb56351808ce53909fbe45/packages/utils/src/instrument.ts#L180
@@ -47,8 +47,7 @@ function handleXhr(handlerData: XhrHandlerData): ReplayPerformanceEntry | null {
 
   const { method, url, status_code: statusCode } = handlerData.xhr.__sentry_xhr__ || {};
 
-  // Do not capture fetches to Sentry ingestion endpoint
-  if (url === undefined || isIngestHost(url)) {
+  if (url === undefined) {
     return null;
   }
 
@@ -79,6 +78,10 @@ export function handleXhrSpanListener(replay: ReplayContainer): (handlerData: Xh
       return;
     }
 
+    if (shouldFilterRequest(replay, result.name)) {
+      return;
+    }
+
     replay.addUpdate(() => {
       createPerformanceSpans(replay, [result]);
       // Returning true will cause `addUpdate` to not flush

packages/replay/src/createPerformanceEntry.ts

@@ -3,7 +3,6 @@ import { record } from 'rrweb';
 
 import { WINDOW } from './constants';
 import type { AllPerformanceEntry, PerformanceNavigationTiming, PerformancePaintTiming } from './types';
-import { isIngestHost } from './util/isIngestHost';
 
 export interface ReplayPerformanceEntry {
   /**
@@ -110,11 +109,6 @@ function createNavigationEntry(entry: PerformanceNavigationTiming) {
 function createResourceEntry(entry: PerformanceResourceTiming) {
   const { entryType, initiatorType, name, responseEnd, startTime, encodedBodySize, transferSize } = entry;
 
-  // Do not capture fetches to Sentry ingestion endpoint
-  if (isIngestHost(name)) {
-    return null;
-  }
-
   // Core SDK handles these
   if (['fetch', 'xmlhttprequest'].includes(initiatorType)) {
     return null;

packages/replay/src/util/isIngestHost.ts

@@ -0,0 +1,23 @@
+import { getCurrentHub } from '@sentry/core';
+
+import type { ReplayContainer } from '../types';
+
+/**
+ * Check whether a given request URL should be filtered out.
+ */
+export function shouldFilterRequest(replay: ReplayContainer, url: string): boolean {
+  // If we enabled the `traceInternals` experiment, we want to trace everything
+  if (__DEBUG_BUILD__ && replay.getOptions()._experiments?.traceInternals) {
+    return false;
+  }
+
+  return !_isSentryRequest(url);
+}
+
+/**
+ * Checks wether a given URL belongs to the configured Sentry DSN.
+ */
+function _isSentryRequest(url: string): boolean {
+  const dsn = getCurrentHub().getClient()?.getDsn();
+  return dsn ? url.includes(dsn.host) : false;
+}