Skip to content

Commit 47937fb

Browse files
lobsterkatieAbhiPrasad
authored andcommitted
fix(dev): Restrict size check action to PRs (#5082)
The size check action we use in our main CI workflow will throw an error if run outside of the context of a PR (as when running CI manually, for example). As a result, the overall run is always marked as a failure, even when all other jobs passed. This restricts the action to running on PRs, to avoid that problem.
1 parent e0e653a commit 47937fb

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@ jobs:
109109
needs: job_build
110110
timeout-minutes: 15
111111
runs-on: ubuntu-latest
112+
# Size Check will error out outside of the context of a PR
113+
if: ${{ github.event_name == 'pull_request' }}
112114
steps:
113115
- name: Check out current commit (${{ env.HEAD_COMMIT }})
114116
uses: actions/checkout@v2

0 commit comments

Comments
 (0)