build: Add no-optional-chaining eslint rule

Author: mydea

packages/eslint-config-sdk/src/index.js

@@ -143,8 +143,9 @@ module.exports = {
           },
         ],
 
-        // We want to prevent async await usage in our files to prevent uncessary bundle size. Turned off in tests.
+        // We want to prevent async await & optional chaining usage in our files to prevent uncessary bundle size. Turned off in tests.
         '@sentry-internal/sdk/no-async-await': 'error',
+        '@sentry-internal/sdk/no-optional-chaining': 'error',
 
         // JSDOC comments are required for classes and methods. As we have a public facing codebase, documentation,
         // even if it may seems excessive at times, is important to emphasize. Turned off in tests.
@@ -178,6 +179,7 @@ module.exports = {
         '@typescript-eslint/no-non-null-assertion': 'off',
         '@typescript-eslint/no-empty-function': 'off',
         '@sentry-internal/sdk/no-async-await': 'off',
+        '@sentry-internal/sdk/no-optional-chaining': 'off',
       },
     },
     {

packages/eslint-plugin-sdk/src/index.js

@@ -11,6 +11,7 @@
 module.exports = {
   rules: {
     'no-async-await': require('./rules/no-async-await'),
+    'no-optional-chaining': require('./rules/no-optional-chaining'),
     'no-eq-empty': require('./rules/no-eq-empty'),
   },
 };

packages/eslint-plugin-sdk/src/rules/no-optional-chaining.js

@@ -0,0 +1,61 @@
+/**
+ * @fileoverview Rule to disallow using optional chaining - because this is transpiled into verbose code.
+ * @author Francesco Novy
+ *
+ * Based on https://github.com/facebook/lexical/pull/3233
+ */
+'use strict';
+
+// ------------------------------------------------------------------------------
+// Rule Definition
+// ------------------------------------------------------------------------------
+
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow usage of optional chaining',
+      category: 'Best Practices',
+      recommended: true,
+    },
+    messages: {
+      forbidden: 'Avoid using optional chaining',
+    },
+    fixable: null,
+    schema: [],
+  },
+
+  create(context) {
+    const sourceCode = context.getSourceCode();
+
+    /**
+     * Checks if the given token is a `?.` token or not.
+     * @param {Token} token The token to check.
+     * @returns {boolean} `true` if the token is a `?.` token.
+     */
+    function isQuestionDotToken(token) {
+      return (
+        token.value === '?.' &&
+        (token.type === 'Punctuator' || // espree has been parsed well.
+          // [email protected] doesn't parse "?." tokens well. Therefore, get the string from the source code and check it.
+          sourceCode.getText(token) === '?.')
+      );
+    }
+
+    return {
+      'CallExpression[optional=true]'(node) {
+        context.report({
+          messageId: 'forbidden',
+          node: sourceCode.getTokenAfter(node.callee, isQuestionDotToken),
+        });
+      },
+      'MemberExpression[optional=true]'(node) {
+        context.report({
+          messageId: 'forbidden',
+          node: sourceCode.getTokenAfter(node.object, isQuestionDotToken),
+        });
+      },
+    };
+  },
+};

packages/nextjs/.eslintrc.js

@@ -10,6 +10,7 @@ module.exports = {
   extends: ['../../.eslintrc.js'],
   rules: {
     '@sentry-internal/sdk/no-async-await': 'off',
+    '@sentry-internal/sdk/no-optional-chaining': 'off',
   },
   overrides: [
     {

packages/node/.eslintrc.js

@@ -5,5 +5,6 @@ module.exports = {
   extends: ['../../.eslintrc.js'],
   rules: {
     '@sentry-internal/sdk/no-async-await': 'off',
+    '@sentry-internal/sdk/no-optional-chaining': 'off',
   },
 };

packages/opentelemetry-node/.eslintrc.js

@@ -5,5 +5,6 @@ module.exports = {
   extends: ['../../.eslintrc.js'],
   rules: {
     '@sentry-internal/sdk/no-async-await': 'off',
+    '@sentry-internal/sdk/no-optional-chaining': 'off',
   },
 };

packages/remix/.eslintrc.js

@@ -10,6 +10,7 @@ module.exports = {
   extends: ['../../.eslintrc.js'],
   rules: {
     '@sentry-internal/sdk/no-async-await': 'off',
+    '@sentry-internal/sdk/no-optional-chaining': 'off',
   },
   overrides: [
     {

packages/serverless/.eslintrc.js

@@ -5,6 +5,7 @@ module.exports = {
   extends: ['../../.eslintrc.js'],
   rules: {
     '@sentry-internal/sdk/no-async-await': 'off',
+    '@sentry-internal/sdk/no-optional-chaining': 'off',
   },
   overrides: [
     {

packages/wasm/.eslintrc.js

@@ -1,3 +1,6 @@
 module.exports = {
   extends: ['../../.eslintrc.js'],
+  rules: {
+    '@sentry-internal/sdk/no-optional-chaining': 'off',
+  },
 };