Skip to content

Commit 4d3e188

Browse files
committed
remove outdated TODO
1 parent 7269e2f commit 4d3e188

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

packages/tracing/src/browser/request.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,6 @@ export function instrumentOutgoingRequests(_options?: Partial<RequestInstrumenta
143143
* A function that determines whether to attach tracing headers to a request.
144144
* This was extracted from `instrumentOutgoingRequests` to make it easier to test shouldAttachHeaders.
145145
* We only export this fuction for testing purposes.
146-
*
147-
* TODO (v8): Remove `tracingOrigins` which should drastically simplify this function.
148146
*/
149147
export function shouldAttachHeaders(url: string, tracePropagationTargets: (string | RegExp)[] | undefined): boolean {
150148
return stringMatchesSomePattern(url, tracePropagationTargets || DEFAULT_TRACE_PROPAGATION_TARGETS);

packages/tracing/test/browser/request.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,6 @@ describe('callbacks', () => {
391391
});
392392
});
393393

394-
// TODO (v8): Adapt these tests once we remove `tracingOrigins`
395394
describe('shouldAttachHeaders', () => {
396395
describe('should prefer `tracePropagationTargets` over defaults', () => {
397396
it('should return `true` if the url matches the new tracePropagationTargets', () => {

0 commit comments

Comments
 (0)