feat(tracing): Add GB unit to device memory tag value (#4935)

dashed · lobsterkatie · commit 57c7c3295a8c · 2022-04-26T13:13:54.000-07:00
Since tag values are always strings, it'll be useful to attach units to the `deviceMemory` tag. Since `navigator.deviceMemory` are approximate in gigabytes, we can suffix the tag value with " GB". Reference: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/deviceMemory
diff --git a/packages/tracing/src/browser/metrics.ts b/packages/tracing/src/browser/metrics.ts
@@ -211,7 +211,7 @@ export class MetricsInstrumentation {
     }
 
     if (isMeasurementValue(navigator.deviceMemory)) {
-      transaction.setTag('deviceMemory', String(navigator.deviceMemory));
+      transaction.setTag('deviceMemory', `${navigator.deviceMemory} GB`);
     }
 
     if (isMeasurementValue(navigator.hardwareConcurrency)) {

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ export class MetricsInstrumentation {`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`if (isMeasurementValue(navigator.deviceMemory)) {`
`214`		`- transaction.setTag('deviceMemory', String(navigator.deviceMemory));`
	`214`	+ transaction.setTag('deviceMemory', `${navigator.deviceMemory} GB`);
`215`	`215`	`}`
`216`	`216`
`217`	`217`	`if (isMeasurementValue(navigator.hardwareConcurrency)) {`