Skip to content

Commit 5adcbe2

Browse files
committed
fix type
1 parent 654b495 commit 5adcbe2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/tracing/src/browser/browsertracing.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { DEFAULT_IDLE_TIMEOUT, IdleTransaction } from '../idletransaction';
77
import { SpanStatus } from '../spanstatus';
88
import { extractTraceparentData, secToMs } from '../utils';
99
import { registerBackgroundTabDetection } from './backgroundtab';
10-
import { MetricsInstrumentation, MetricsInstrumentationOptions } from './metrics';
10+
import { DEFAULT_METRICS_INSTR_OPTIONS, MetricsInstrumentation, MetricsInstrumentationOptions } from './metrics';
1111
import {
1212
defaultRequestInstrumentationOptions,
1313
instrumentOutgoingRequests,
@@ -149,7 +149,7 @@ export class BrowserTracing implements Integration {
149149
tracingOrigins,
150150
};
151151

152-
this._metrics = new MetricsInstrumentation(this.options._metricOptions);
152+
this._metrics = new MetricsInstrumentation({ ...this.options._metricOptions, ...DEFAULT_METRICS_INSTR_OPTIONS });
153153
}
154154

155155
/**

packages/tracing/src/browser/metrics.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export interface MetricsInstrumentationOptions {
2121
_reportAllChanges: boolean;
2222
}
2323

24-
const DEFAULT_METRICS_INSTR_OPTIONS: MetricsInstrumentationOptions = {
24+
export const DEFAULT_METRICS_INSTR_OPTIONS: MetricsInstrumentationOptions = {
2525
_reportAllChanges: false,
2626
};
2727

@@ -33,7 +33,7 @@ export class MetricsInstrumentation {
3333
private _lcpEntry: LargestContentfulPaint | undefined;
3434
private _clsEntry: LayoutShift | undefined;
3535

36-
public constructor(_options: MetricsInstrumentationOptions = DEFAULT_METRICS_INSTR_OPTIONS) {
36+
public constructor(_options: MetricsInstrumentationOptions) {
3737
if (!isNodeEnv() && global?.performance) {
3838
if (global.performance.mark) {
3939
global.performance.mark('sentry-tracing-init');

0 commit comments

Comments
 (0)