add unit tests

Author: Lms24

packages/tracing/test/browser/browsertracing.test.ts

@@ -34,6 +34,15 @@ jest.mock('@sentry/utils', () => {
 
 jest.mock('../../src/browser/metrics');
 
+const instrumentOutgoingRequestsMock = jest.fn();
+jest.mock('./../../src/browser/request', () => {
+  const actual = jest.requireActual('./../../src/browser/request');
+  return {
+    ...actual,
+    instrumentOutgoingRequests: (options: Partial<BrowserTracingOptions>) => instrumentOutgoingRequestsMock(options),
+  };
+});
+
 beforeAll(() => {
   const dom = new JSDOM();
   // @ts-ignore need to override global document
@@ -128,6 +137,7 @@ describe('BrowserTracing', () => {
       expect(transaction.endTimestamp).toBe(span.endTimestamp);
     });
 
+    // TODO (v8): remove these tests
     describe('tracingOrigins', () => {
       it('sets tracing origins if provided and does not warn', () => {
         const sampleTracingOrigins = ['something'];
@@ -152,6 +162,43 @@ describe('BrowserTracing', () => {
       });
     });
 
+    describe('tracePropagationTargets', () => {
+      it('sets tracePropagationTargets if provided', () => {
+        const sampleTracePropagationTargets = ['something'];
+        const inst = createBrowserTracing(true, {
+          routingInstrumentation: customInstrumentRouting,
+          tracePropagationTargets: sampleTracePropagationTargets,
+        });
+
+        expect(inst.options.tracePropagationTargets).toEqual(sampleTracePropagationTargets);
+      });
+
+      it('sets tracePropagationTargets to an empty array and does not warn', () => {
+        const sampleTracePropagationTargets: string[] = [];
+        const inst = createBrowserTracing(true, {
+          routingInstrumentation: customInstrumentRouting,
+          tracePropagationTargets: sampleTracePropagationTargets,
+        });
+
+        expect(inst.options.tracePropagationTargets).toEqual(sampleTracePropagationTargets);
+      });
+
+      it('correctly passes tracePropagationTargets to `instrumentOutgoingRequests` in `setupOnce`', () => {
+        jest.clearAllMocks();
+        const sampleTracePropagationTargets = ['something'];
+        createBrowserTracing(true, {
+          routingInstrumentation: customInstrumentRouting,
+          tracePropagationTargets: sampleTracePropagationTargets,
+        });
+
+        expect(instrumentOutgoingRequestsMock).toHaveBeenCalledWith({
+          traceFetch: true,
+          traceXHR: true,
+          tracePropagationTargets: ['something'],
+        });
+      });
+    });
+
     describe('beforeNavigate', () => {
       it('is called on transaction creation', () => {
         const mockBeforeNavigation = jest.fn().mockReturnValue({ name: 'here/is/my/path' });

packages/tracing/test/browser/request.test.ts

@@ -392,32 +392,18 @@ describe('callbacks', () => {
 });
 
 // TODO (v8): Adapt these tests once we remove `tracingOrigins`
-describe('[pre-v8]: shouldAttachHeaders', () => {
-  describe('prefer `tracePropagationTargets` over `tracingOrigins`', () => {
+describe('shouldAttachHeaders', () => {
+  describe('should prefer `tracePropagationTargets` over defaults', () => {
     it('should return `true` if the url matches the new tracePropagationTargets', () => {
-      expect(shouldAttachHeaders('http://example.com', ['example.com'], undefined)).toBe(true);
+      expect(shouldAttachHeaders('http://example.com', ['example.com'])).toBe(true);
     });
 
     it('should return `false` if tracePropagationTargets array is empty', () => {
-      expect(shouldAttachHeaders('http://localhost:3000/test', [], ['localhost'])).toBe(false);
+      expect(shouldAttachHeaders('http://localhost:3000/test', [])).toBe(false);
     });
 
     it("should return `false` if tracePropagationTargets array doesn't match", () => {
-      expect(shouldAttachHeaders('http://localhost:3000/test', ['example.com'], ['localhost'])).toBe(false);
-    });
-  });
-
-  describe('tracingOrigins backwards compatibility (tracePropagationTargets not defined)', () => {
-    it('should return `true` if the url matches tracingOrigns', () => {
-      expect(shouldAttachHeaders('http://example.com', undefined, ['example.com'])).toBe(true);
-    });
-
-    it('should return `false` if tracePropagationTargets array is empty', () => {
-      expect(shouldAttachHeaders('http://localhost:3000/test', undefined, [])).toBe(false);
-    });
-
-    it("should return `false` if tracePropagationTargets array doesn't match", () => {
-      expect(shouldAttachHeaders('http://localhost:3000/test', undefined, ['example.com'])).toBe(false);
+      expect(shouldAttachHeaders('http://localhost:3000/test', ['example.com'])).toBe(false);
     });
   });
 
@@ -428,11 +414,11 @@ describe('[pre-v8]: shouldAttachHeaders', () => {
       'http://somewhere.com/test/localhost/123',
       'http://somewhere.com/test?url=localhost:3000&test=123',
     ])('return `true` for urls matching defaults (%s)', url => {
-      expect(shouldAttachHeaders(url, undefined, undefined)).toBe(true);
+      expect(shouldAttachHeaders(url, undefined)).toBe(true);
     });
 
     it.each(['notmydoman/api/test', 'example.com'])('return `false` for urls not matching defaults (%s)', url => {
-      expect(shouldAttachHeaders(url, undefined, undefined)).toBe(false);
+      expect(shouldAttachHeaders(url, undefined)).toBe(false);
     });
   });
 });