Skip to content

Commit 87eb00f

Browse files
committed
Use portfinder as late as possible.
1 parent 04558a9 commit 87eb00f

File tree

1 file changed

+8
-6
lines changed
  • packages/remix/test/integration/test/server/utils

1 file changed

+8
-6
lines changed

packages/remix/test/integration/test/server/utils/helpers.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import express from 'express';
22
import { createRequestHandler } from '@remix-run/express';
3-
import { getPortPromise } from 'portfinder';
3+
import { getPort, getPortPromise } from 'portfinder';
44
import { wrapExpressCreateRequestHandler } from '@sentry/remix';
55
import { TestEnv } from '../../../../../../node-integration-tests/utils';
66
import * as http from 'http';
@@ -16,18 +16,20 @@ export class RemixTestEnv extends TestEnv {
1616
const requestHandlerFactory =
1717
adapter === 'express' ? wrapExpressCreateRequestHandler(createRequestHandler) : createRequestHandler;
1818

19-
const port = await getPortPromise();
20-
19+
let serverPort;
2120
const server = await new Promise<http.Server>(resolve => {
2221
const app = express();
2322

2423
app.all('*', requestHandlerFactory({ build: require('../../../build') }));
2524

26-
const server = app.listen(port, () => {
27-
resolve(server);
25+
getPort((_, port) => {
26+
serverPort = port;
27+
const server = app.listen(port, () => {
28+
resolve(server);
29+
});
2830
});
2931
});
3032

31-
return new RemixTestEnv(server, `http://localhost:${port}`);
33+
return new RemixTestEnv(server, `http://localhost:${serverPort}`);
3234
}
3335
}

0 commit comments

Comments
 (0)