add another sdk interop test

Lms24 · Lms24 · commit 8f8c99d5ebe7 · 2024-05-24T15:52:42.000+02:00
diff --git a/dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/init.js b/dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/init.js
@@ -0,0 +1,19 @@
+import * as Sentry from '@sentry/browser';
+
+/**
+ * This simulates an relatively new v7 SDK setting acs on the __SENTRY__ carrier.
+ * see: https://github.com/getsentry/sentry-javascript/issues/12054
+ */
+window.__SENTRY__ = {
+  acs: {
+    getCurrentScope: () => {
+      return 'scope';
+    },
+  },
+};
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+});
diff --git a/dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/subject.js b/dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/subject.js
@@ -0,0 +1,10 @@
+const sentryCarrier = window && window.__SENTRY__;
+
+/**
+ * Simulate an old pre v8 SDK obtaining the hub from the global sentry carrier
+ * and checking for the hub version.
+ */
+const res = sentryCarrier.acs && sentryCarrier.acs.getCurrentScope();
+
+// Write back result into the document
+document.getElementById('currentScope').innerText = res && 'scope';
diff --git a/dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/template.html b/dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/template.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+  </head>
+  <body>
+    <p id="currentScope"></p>
+  </body>
+</html>
diff --git a/dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/test.ts b/dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/test.ts
@@ -0,0 +1,13 @@
+import { expect } from '@playwright/test';
+
+import { sentryTest } from '../../../../utils/fixtures';
+
+sentryTest(
+  "doesn't crash if older SDKs access `acs.getCurrentScope` on the global object",
+  async ({ getLocalTestUrl, page }) => {
+    const url = await getLocalTestUrl({ testDir: __dirname });
+    await page.goto(url);
+
+    await expect(page.locator('#currentScope')).toHaveText('scope');
+  },
+);
diff --git a/dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/init.js b/dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/init.js
@@ -2,6 +2,7 @@ import * as Sentry from '@sentry/browser';
 
 /**
  * This simulates an old, pre-v8 SDK setting itself up on the global __SENTRY__ carrier.
+ * see: https://github.com/getsentry/sentry-javascript/issues/12155
  */
 window.__SENTRY__ = {
   hub: {
diff --git a/dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/subject.js b/dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/subject.js
@@ -8,5 +8,3 @@ const res = sentryCarrier.hub && sentryCarrier.hub.isOlderThan(7);
 
 // Write back result into the document
 document.getElementById('olderThan').innerText = res;
-
-console.log(sentryCarrier);
diff --git a/dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/template.html b/dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/template.html
diff --git a/dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/test.ts b/dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/test.ts
@@ -1,6 +1,6 @@
 import { expect } from '@playwright/test';
 
-import { sentryTest } from '../../../utils/fixtures';
+import { sentryTest } from '../../../../utils/fixtures';
 
 sentryTest(
   "doesn't crash if older SDKs access `hub.isOlderThan` on the global object",
