ref trigger user activity

Author: mydea

packages/replay/src/coreHandlers/handleHistory.ts

@@ -39,12 +39,14 @@ export function handleHistorySpanListener(replay: ReplayContainer): (handlerData
 
     // Need to collect visited URLs
     replay.getContext().urls.push(result.name);
-    replay.triggerUserActivity();
-
-    replay.addUpdate(() => {
-      createPerformanceSpans(replay, [result]);
-      // Returning false to flush
-      return false;
+    replay.updateUserActivity();
+
+    replay.checkSessionState(() => {
+      replay.addUpdate(() => {
+        createPerformanceSpans(replay, [result]);
+        // Returning false to flush
+        return false;
+      });
     });
   };
 }

packages/replay/src/coreHandlers/util/addBreadcrumbEvent.ts

@@ -13,27 +13,25 @@ export function addBreadcrumbEvent(replay: ReplayContainer, breadcrumb: Breadcru
   }
 
   if (['ui.click', 'ui.input'].includes(breadcrumb.category as string)) {
-    replay.triggerUserActivity();
-  } else {
-    replay.checkSessionState(() => {
-      // noop
-    });
+    replay.updateUserActivity();
   }
 
-  replay.addUpdate(() => {
-    void replay.throttledAddEvent({
-      type: EventType.Custom,
-      // TODO: We were converting from ms to seconds for breadcrumbs, spans,
-      // but maybe we should just keep them as milliseconds
-      timestamp: (breadcrumb.timestamp || 0) * 1000,
-      data: {
-        tag: 'breadcrumb',
-        // normalize to max. 10 depth and 1_000 properties per object
-        payload: normalize(breadcrumb, 10, 1_000),
-      },
-    });
+  replay.checkSessionState(() => {
+    replay.addUpdate(() => {
+      void replay.throttledAddEvent({
+        type: EventType.Custom,
+        // TODO: We were converting from ms to seconds for breadcrumbs, spans,
+        // but maybe we should just keep them as milliseconds
+        timestamp: (breadcrumb.timestamp || 0) * 1000,
+        data: {
+          tag: 'breadcrumb',
+          // normalize to max. 10 depth and 1_000 properties per object
+          payload: normalize(breadcrumb, 10, 1_000),
+        },
+      });
 
-    // Do not flush after console log messages
-    return breadcrumb.category === 'console';
+      // Do not flush after console log messages
+      return breadcrumb.category === 'console';
+    });
   });
 }

packages/replay/src/replay.ts

@@ -437,24 +437,7 @@ export class ReplayContainer implements ReplayContainerInterface {
   }
 
   /**
-   * Updates the user activity timestamp and resumes recording. This should be
-   * called in an event handler for a user action that we consider as the user
-   * being "active" (e.g. a mouse click).
-   */
-  public triggerUserActivity(): void {
-    this._updateSessionActivity();
-
-    this.checkSessionState(() => {
-      // noop
-    });
-  }
-
-  /**
-   * Updates the user activity timestamp *without* resuming
-   * recording. Some user events (e.g. keydown) can be create
-   * low-value replays that only contain the keypress as a
-   * breadcrumb. Instead this would require other events to
-   * create a new replay after a session has expired.
+   * Updates the user activity timestamp.
    */
   public updateUserActivity(): void {
     this._updateSessionActivity();

packages/replay/src/types/replay.ts

@@ -421,7 +421,6 @@ export interface ReplayContainer {
   flush(): Promise<void>;
   flushImmediate(): Promise<void>;
   cancelFlush(): void;
-  triggerUserActivity(): void;
   updateUserActivity(): void;
   addUpdate(cb: AddUpdateCallback): void;
   getOptions(): ReplayPluginOptions;