Skip to content

Commit a7eaf2f

Browse files
committed
Misc code review comments added
1 parent dc45975 commit a7eaf2f

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

packages/browser/src/transports/fetch.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ export class FetchTransport extends BaseTransport {
163163
}),
164164
)
165165
.then(undefined, reason => {
166+
// It's either buffer rejection or any other xhr/fetch error, which are treated as NetworkError.
166167
if (reason instanceof SentryError) {
167168
this.recordLostEvent(Outcome.QueueOverflow, sentryRequest.type);
168169
} else {

packages/browser/src/transports/xhr.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ export class XHRTransport extends BaseTransport {
6464
}),
6565
)
6666
.then(undefined, reason => {
67+
// It's either buffer rejection or any other xhr/fetch error, which are treated as NetworkError.
6768
if (reason instanceof SentryError) {
6869
this.recordLostEvent(Outcome.QueueOverflow, sentryRequest.type);
6970
} else {

packages/types/src/transport.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export interface TransportOptions {
6565
fetchParameters?: { [key: string]: string };
6666
/** The envelope tunnel to use. */
6767
tunnel?: string;
68-
/** Automatically send SDK Client Report */
68+
/** Send SDK Client Reports. Enabled by default. */
6969
sendClientReports?: boolean;
7070
/**
7171
* Set of metadata about the SDK that can be internally used to enhance envelopes and events,

0 commit comments

Comments
 (0)