Skip to content

Commit b305ee8

Browse files
committed
fix node 8 tests
1 parent f4ca6bf commit b305ee8

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

scripts/test.ts

+9
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { spawnSync } from 'child_process';
2+
import * as fs from 'fs';
23
import { join } from 'path';
34

45
function run(cmd: string, cwd: string = '') {
@@ -37,6 +38,7 @@ if (nodeMajorVersion <= 10) {
3738
'@sentry/gatsby',
3839
'@sentry/serverless',
3940
'@sentry/nextjs',
41+
'@sentry/angular',
4042
];
4143

4244
// This is a hack, to deal the fact that the browser-based tests fail under Node 8, because of a conflict buried
@@ -46,6 +48,13 @@ if (nodeMajorVersion <= 10) {
4648
// against a single version of node, but in the short run, this at least allows us to not be blocked by the
4749
// failures.)
4850
run('rm -rf packages/tracing/test/browser');
51+
52+
// TODO Pull this out once we switch to sucrase builds
53+
// change the tsconfig `target` back to es5, so as not to have to fix a compatibility problem that will soon be moot
54+
const baseTSConfig = 'packages/typescript/tsconfig.json';
55+
fs.writeFileSync(baseTSConfig, String(fs.readFileSync(baseTSConfig)).replace('"target": "es6"', '"target": "es5"'));
56+
run(`yarn build:dev ${ignorePackages.map(dep => `--ignore="${dep}"`).join(' ')}`);
57+
// fs.writeFileSync(baseTSConfig, String(fs.readFileSync(baseTSConfig)).replace('"target": "es5"', '"target": "es6"'));
4958
}
5059
// Node 10
5160
else {

0 commit comments

Comments
 (0)