Skip to content

Commit d3adc31

Browse files
committed
build: Move build related unit test into own job
We shouldn't be asserting on built assets (dist/esm) in our unit tests. This helps unblock #4616
1 parent dee05a6 commit d3adc31

File tree

3 files changed

+7
-25
lines changed

3 files changed

+7
-25
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,11 @@ jobs:
411411
with:
412412
path: ${{ env.CACHED_BUILD_PATHS }}
413413
key: ${{ env.BUILD_CACHE_KEY }}
414-
- name: Run build tests
414+
- name: Run browser build tests
415415
run: |
416416
cd packages/browser
417417
yarn test:package
418+
- name: Run utils build tests
419+
run: |
420+
cd packages/utils
421+
yarn test:package

packages/utils/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@
4545
"lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
4646
"pack": "npm pack",
4747
"test": "jest",
48-
"test:watch": "jest --watch"
48+
"test:watch": "jest --watch",
49+
"test:package": "node test/package/build.js"
4950
},
5051
"volta": {
5152
"extends": "../../package.json"

packages/utils/test/build.test.ts

Lines changed: 0 additions & 23 deletions
This file was deleted.

0 commit comments

Comments
 (0)