move assertions around with new client

Author: AbhiPrasad

packages/opentelemetry-node/test/spanprocessor.test.ts

@@ -766,13 +766,20 @@ describe('SentrySpanProcessor', () => {
   });
 
   it('associates an error to a transaction', () => {
-    let sentryEvent: any;
     let otelSpan: any;
 
+    expect.assertions(3);
+
     client = new NodeClient({
       ...DEFAULT_NODE_CLIENT_OPTIONS,
-      beforeSend: event => {
-        sentryEvent = event;
+      beforeSend: sentryEvent => {
+        expect(sentryEvent).toBeDefined();
+        expect(sentryEvent.exception).toBeDefined();
+        expect(sentryEvent.contexts?.trace).toEqual({
+          parent_span_id: otelSpan.parentSpanId,
+          span_id: otelSpan.spanContext().spanId,
+          trace_id: otelSpan.spanContext().traceId,
+        });
         return null;
       },
     });
@@ -790,24 +797,28 @@ describe('SentrySpanProcessor', () => {
 
       parentOtelSpan.end();
     });
-
-    expect(sentryEvent).toBeDefined();
-    expect(sentryEvent.exception).toBeDefined();
-    expect(sentryEvent.contexts.trace).toEqual({
-      parent_span_id: otelSpan.parentSpanId,
-      span_id: otelSpan.spanContext().spanId,
-      trace_id: otelSpan.spanContext().traceId,
-    });
   });
 
   it('generates Sentry errors from opentelemetry span exception events', () => {
-    let sentryEvent: any;
     let otelSpan: any;
 
+    expect.assertions(4);
+
     client = new NodeClient({
       ...DEFAULT_NODE_CLIENT_OPTIONS,
-      beforeSend: event => {
-        sentryEvent = event;
+      beforeSend: sentryEvent => {
+        expect(sentryEvent).toBeDefined();
+        expect(sentryEvent.exception).toBeDefined();
+        expect(sentryEvent.exception?.values?.[0]).toEqual({
+          mechanism: expect.any(Object),
+          type: 'Error',
+          value: 'this is an otel error!',
+        });
+        expect(sentryEvent.contexts?.trace).toEqual({
+          parent_span_id: otelSpan.parentSpanId,
+          span_id: otelSpan.spanContext().spanId,
+          trace_id: otelSpan.spanContext().traceId,
+        });
         return null;
       },
     });
@@ -825,19 +836,6 @@ describe('SentrySpanProcessor', () => {
 
       parentOtelSpan.end();
     });
-
-    expect(sentryEvent).toBeDefined();
-    expect(sentryEvent.exception).toBeDefined();
-    expect(sentryEvent.exception.values[0]).toEqual({
-      mechanism: expect.any(Object),
-      type: 'Error',
-      value: 'this is an otel error!',
-    });
-    expect(sentryEvent.contexts.trace).toEqual({
-      parent_span_id: otelSpan.parentSpanId,
-      span_id: otelSpan.spanContext().spanId,
-      trace_id: otelSpan.spanContext().traceId,
-    });
   });
 
   // Regression test for https://github.com/getsentry/sentry-javascript/issues/7538