Skip to content

Commit f05cdeb

Browse files
committed
feat(otel): Move instrumenter option to base ClientOptions
1 parent 8f593f9 commit f05cdeb

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

packages/node/src/types.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ClientOptions, Instrumenter, Options, TracePropagationTargets } from '@sentry/types';
1+
import { ClientOptions, Options, TracePropagationTargets } from '@sentry/types';
22

33
import { NodeTransportOptions } from './transports';
44

@@ -19,15 +19,6 @@ export interface BaseNodeOptions {
1919
*/
2020
tracePropagationTargets?: TracePropagationTargets;
2121

22-
/**
23-
* The instrumenter to use. Defaults to `sentry`.
24-
* When not set to `sentry`, auto-instrumentation inside of Sentry will be disabled,
25-
* in favor of using external auto instrumentation.
26-
*
27-
* NOTE: Any option except for `sentry` is highly experimental and subject to change!
28-
*/
29-
instrumenter?: Instrumenter;
30-
3122
/** Callback that is executed when a fatal global error occurs. */
3223
onFatalError?(error: Error): void;
3324
}

packages/types/src/options.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Breadcrumb, BreadcrumbHint } from './breadcrumb';
22
import { Event, EventHint } from './event';
3+
import { Instrumenter } from './instrumenter';
34
import { Integration } from './integration';
45
import { CaptureContext } from './scope';
56
import { SdkMetadata } from './sdkmetadata';
@@ -58,6 +59,15 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
5859
*/
5960
integrations: Integration[];
6061

62+
/**
63+
* The instrumenter to use. Defaults to `sentry`.
64+
* When not set to `sentry`, auto-instrumentation inside of Sentry will be disabled,
65+
* in favor of using external auto instrumentation.
66+
*
67+
* NOTE: Any option except for `sentry` is highly experimental and subject to change!
68+
*/
69+
instrumenter?: Instrumenter;
70+
6171
/**
6272
* A function that takes transport options and returns the Transport object which is used to send events to Sentry.
6373
* The function is invoked internally when the client is initialized.

0 commit comments

Comments
 (0)