Skip to content

Commit f8eff24

Browse files
Lms24lforst
andauthored
Apply suggestions from code review
Co-authored-by: Luca Forstner <[email protected]>
1 parent 8fdc163 commit f8eff24

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

MIGRATION.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ We introduced a new way of propagating tracing and transaction-related informati
327327
change adds the [`baggage` HTTP header](https://www.w3.org/TR/baggage/) to outgoing requests if the instrumentation of requests is enabled. Since this adds a header to your HTTP requests, you might need
328328
to adjust your Server's CORS settings to allow this additional header. Take a look at the [Sentry docs](https://docs.sentry.io/platforms/javascript/performance/connect-services/#navigation-and-other-xhr-requests)
329329
for more in-depth instructions what to change.
330+
330331
## General API Changes
331332

332333
For our efforts to reduce bundle size of the SDK we had to remove and refactor parts of the package which introduced a few changes to the API:

packages/utils/src/baggage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export function parseBaggageString(inputBaggageString: string): Baggage {
8787
* a possibly created or modified baggage header by a third party that's been added
8888
* to the outgoing request header.
8989
*
90-
* In case @param headerBaggage exists, we can safely add the the 3rd party part of @param headerBaggage
90+
* In case @param headerBaggageString exists, we can safely add the the 3rd party part of @param headerBaggage
9191
* with our @param incomingBaggage. This is possible because if we modified anything beforehand,
9292
* it would only affect parts of the sentry baggage (@see Baggage interface).
9393
*

0 commit comments

Comments
 (0)