Skip to content

V8 causes error with Square payment form #12151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
JLuse opened this issue May 21, 2024 · 5 comments
Closed
3 tasks done

V8 causes error with Square payment form #12151

JLuse opened this issue May 21, 2024 · 5 comments
Labels
Package: react Issues related to the Sentry React SDK Stale

Comments

@JLuse
Copy link

JLuse commented May 21, 2024

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/react

SDK Version

8

Framework Version

No response

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

Reported by a customer who has mentioned the following:
upgrading to Sentry JS V8 breaks the Square payment form (square.js) because they have this line in their code:

!!(t && t.__SENTRY__ && t.__SENTRY__.hub) && !qe(e).isOlderThan(Me) || Ve(e, new je),

And isOlderThan is no longer exposed in v8.

Example in support ticket - https://sentry.zendesk.com/agent/tickets/121772

Expected Result

SDK to work with Square forms

Actual Result

Error occurs

@mydea
Copy link
Member

mydea commented May 23, 2024

Hey, we are looking into ways to handle this better. This happens because of mismatching versions of the SDK being run at the same time, which is subject to break and lead to conflicts. ideally this can/should be avoided anyhow, but we'll make some adjustments to avoid breaking in such cases.

@getsantry
Copy link

getsantry bot commented Jul 2, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jul 2, 2024
@ziemkowski
Copy link

It appears that Square has published a workaround. I now have V8 and Square in production. So while this may well be an issue elsewhere, it no longer causes a JS error when using the Square Web Payments SDK.

For reference, the Square JS file is located here: https://web.squarecdn.com/v1/square.js

@getsantry getsantry bot moved this from Waiting for: Community to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 9, 2024
@getsantry getsantry bot removed the Stale label Jul 10, 2024
@lforst
Copy link
Contributor

lforst commented Jul 10, 2024

@ziemkowski that's good to know. Thanks for giving a heads up!

@JLuse is this issue also solved for you?

@getsantry
Copy link

getsantry bot commented Nov 23, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 23, 2024
@getsantry getsantry bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react Issues related to the Sentry React SDK Stale
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants