Skip to content

Add knexIntegration to Node #13311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mydea opened this issue Aug 12, 2024 · 1 comment · Fixed by #13526
Closed

Add knexIntegration to Node #13311

mydea opened this issue Aug 12, 2024 · 1 comment · Fixed by #13526
Assignees
Labels

Comments

@mydea
Copy link
Member

mydea commented Aug 12, 2024

Description

We want to instrument knex. There is an existing OTEL instrumentation for this:

https://www.npmjs.com/package/@opentelemetry/instrumentation-knex

### Tasks
- [ ] Add new `knexIntegration` in `@sentry/node`
- [ ] This should set up the OTEL instrumentation
- [ ] Make sure to add an `origin` to all spans the integration emits
- [ ] This is a DB integration, make sure it aligns with the DB span schema we expect.
- [ ] Add node-integration-tests for the package
- [ ] The integration should be added by default
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #13526, which was included in the 8.38.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants