-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Running sentry with Ember embroider and fastboot breaks build #3174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@k-fish would you be able to respond to this? |
Hey there 👋 , I would expect that it might have something to do with the config being available in fastboot, embroider should be fine. Can you try with fastboot disabled? |
Hi, ok so sentry is not supported if I run fastboot? As mentioned earlier it does work when run without fastboot. Eg visiting It also worked before updating to building with embroider. |
@oscarni sorry about that I missed the part about fastboot in your original post. The addon would work with Embroider and Fastboot separately, it just seemed to be an issue with ember-get-config creating a new file via broccoli likely causing a problem. I've removed |
Package + Version
@sentry/browser
@sentry/node
raven-js
raven-node
(raven for node)@sentry/ember
Version:
Description
My ember app is running embroider
0.35.1
in fastboot. It works fine without Sentry or when fastboot is not enabled. But as soon as I add Sentry according to your latest official ember docs (addingInitSentryForEmber()
inapp.js
) the build says:Sentry is using ember-get-config. But it looks like the config is empty from where the sentry import is done.
sentry-javascript/packages/ember/addon/index.ts
Line 15 in 8f66ed8
Not sure if it's an embroider issue or if it's fixable here in the sentry repo. It looks like the config is not accessible from within fastboot when sentry is trying to access it. I also created an issue in the embroider repo embroider-build/embroider#642
The text was updated successfully, but these errors were encountered: