-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Rework how we track sessions #3224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some naming questions (you know me!). Also, do we have any tests covering this?
Otherwise, looks good. 🙂
Co-authored-by: Katie Byers <[email protected]>
I will prepare a beta release from this branch so we can test it on sentry.io |
This reverts commit f25938f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
sentry.io PR |
How we track session now:
init: true
andstatus: ok
-> After sending the session switches toinit: false
in the scopeerror: +1
and send the updateerror: +1
, setstatus: crashed
and send the update-- If the Session was
status: crashed
it staysstatus: crashed
-- If the Session was
status: ok
it will be changed tostatus: exited