Fully anonymous or native stacktraces ignored by allowUrls and denyUrls

[lobsterkatie]

Package + Version

@sentry/browser >= 6.11.0

Description

(Originally a question from a customer)

As of #3842, anonymous and native frames are ignored by allowUrls and denyUrls. This makes sense when, further into the stacktrace, there's a real filename on which to filter. However, there are cases where ignoring such values leaves nothing to filter on (because the stacktrace contains no actual filenames). In those cases, perhaps we should consider reverting to the old behavior, so that such events are again filterable by allowUrls and denyUrls.

[EN: It's not clear how common an issue this is. If you land here because you're having the same problem, please let us know!]

[lobsterkatie]

In the meantime, the filtering can be done manually using beforeSend:

function beforeSend(event, hint) {
  frames = event.exception?.values[0].stacktrace?.frames;
  if (frames) {
    lastFilename = frames[frames.length - 1].filename;
    // as of https://github.com/getsentry/sentry-javascript/pull/3842, these
    // values are ignored by `allowUrls` and `denyUrls` if they're in the last
    // frame
    if (lastFilename === "<anonymous>" || lastFilename === "[native code]") {
      // in some cases, however, they're in *all* the frames, and in those cases
      // we *do* actually want to use the value as a filter
      if (
        frames.every(
          (frame) =>
            !frame.filename ||
            frame.filename === "<anonymous>" ||
            frame.filename === "[native code]"
        )
      ) {
        return null;
      }
    }
  }

  return event;
}

[lobsterkatie]

@onurtemizkan - I think we should wait on this until we know there's a strong need for it.

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[amakhrov]

I definitely have the same cases (example: https://sentry.io/organizations/crunchbase/issues/2843910577/?project=190044)

I ended up with custom code at our side to filter those out in the beforeSend callback (just as suggested in the comment above - I wish I had discovered it earlier :) ).

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀