Skip to content

JS SDK v8 Deprecations List #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AbhiPrasad opened this issue Jun 2, 2022 · 3 comments
Closed

JS SDK v8 Deprecations List #5194

AbhiPrasad opened this issue Jun 2, 2022 · 3 comments
Milestone

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Jun 2, 2022

This PR contains the list of deprecated items that will be removed in the upcoming v8 major version of the SDK.

### Confirmed Removals
- [ ] The utility functions and types in the Node SDK's exported `Handlers` object have been moved out of `Handlers` to the top level of the SDK exports, and `parseRequest` has been renamed `addRequestDataToEvent`. See https://github.com/getsentry/sentry-javascript/pull/5257 and search for `TODO (v8 / #5257)` in the codebase.
- [x] With the introduction of the `tracePropagationTargets` option we can remove `tracingOrigins`. (TODO link PRs and Issues - @lforst)
- [ ] Remove `@sentry/hub` package https://github.com/getsentry/sentry-javascript/issues/5665
- [ ] https://github.com/getsentry/sentry-javascript/issues/10318
- [ ] Remove `componentTrackingPreprocessor` export from Svelte SDK (#5923)
- [ ] Remove guards to calls of optional methods on the `BaseClient` once we made these methods required (#7262, `addIntegration`, `getSdkMetadata`, `on`, `emit`)
- [ ] Remove `withSentry` in favor of `withSentryAPI`
- [ ] Remove SyncPromise
- [ ] Remove `wrap` function (#8897)
- [ ] Remove `@sentry/tracing` package https://github.com/getsentry/sentry-javascript/issues/8796
- [ ] Remove offline integration https://github.com/getsentry/sentry-javascript/pull/9456
- [ ] Remove `static` id property from integrations because static fields could have side effects and are therefore not tree-shakable. (@lforst for more info)
### Up for discussion
- [ ] Stop supporting Angular 10 (and 11) to enable native Ivy support (i.e. get rid of currently necessary `ngcc` coversion). https://github.com/getsentry/sentry-javascript/pull/5253#issuecomment-1154834677
- [ ] Drop support for Node 8/10/12
- [ ] https://github.com/getsentry/sentry-javascript/issues/5907
- [ ] Remove Gatsby Plugin configuration in favour of only using `sentry.config.ts`/`sentry.config.js`
- [ ] `ClientOptions::initialScope` (see https://github.com/getsentry/sentry-docs/issues/5345#issuecomment-1560668770)
- [ ] Remove `TryCatch` integration from exported `defaultIntegration` of Angular(-Ivy) SDKs or write angular-specific tryCatch and refactor global tryCatch (#2744, #5417, https://github.com/getsentry/sentry-javascript/pull/8367#pullrequestreview-1488137672)
- [ ] https://github.com/getsentry/sentry-javascript/issues/8575
- [ ] Remove deprecated `Severity` enum
- [ ] Remove need for DSN if using tunnel https://github.com/getsentry/sentry-javascript/discussions/9377
- [ ] Reconsider all calls to hasTracingEnabled() because of TwP (we use hasTracingEnabled() to detect if performance should be turned on, making the name very misleading because it refers to tracing and not performance, even though that's what it is about)
- [ ] Remove docs for the Node.js AWS Lambda Docker Image (https://github.com/getsentry/sentry-javascript/issues/9762) https://docs.sentry.io/platforms/node/guides/aws-lambda/container-image/
@csvn
Copy link

csvn commented Jun 16, 2022

From: #5253 (comment)

When we first released @sentry/angular, we started with NG10 which means that we want to support this version as long as reasonably possible

In any case, dropping support for an Angular version is a breaking change which means that we'll only be able to do this with the next major release of the SDK.

I've seen many packages have a notice at the top of the README.md, showing what version to install when used with older versions of another library. Maybe it makes sense to have 7.x.x support Angular v10+, and 8.x.x supports only Ivy releases and onwards? Important features could still be backported to between the different versions.

It would be nice to be able to get rid of ngcc conversion and warnings during the build. 😇

@lforst
Copy link
Contributor

lforst commented Aug 2, 2022

Just crossed my mind: We can think about removing the static id fields from integrations since we found it has tree shaking drawbacks. Adding this to "Up for discussion".

@AbhiPrasad
Copy link
Member Author

I think this is pretty much covered by #9508, so closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants