Skip to content

Consider adding integration tests for build code #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lobsterkatie opened this issue Jun 2, 2022 · 2 comments
Closed

Consider adding integration tests for build code #5195

lobsterkatie opened this issue Jun 2, 2022 · 2 comments
Labels

Comments

@lobsterkatie
Copy link
Member

We have a good deal of code which concerns the creation of build artifacts, but none of it is tested in an end-to-end way.

(Right now I'm thinking about all of our rollup config code and the withSentryConfig code in the nextjs SDK, which modifies the user's webpack config in order to change what's in their bundles, but there may be other places as well. The latter does have unit tests, but no integration tests, and the former has no tests at all.)

We should consider having integration tests which run the code and check the emitted artifacts for certain characteristics. For example, do the debug bundles actually contain logging statements? Do the non-debug bundles correctly omit them? Do artifacts end up where we think they should? etc etc.

While we'd have to restrict it to fairly broad characterizations (both to prevent brittleness and to make sure that we're testing things which it's easy to check programmatically), it could at least protect against obvious mistakes.

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@lobsterkatie
Copy link
Member Author

This came up again, so I'm going to reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants