Skip to content

Pass SDK options down as readonly #5248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lforst opened this issue Jun 10, 2022 · 1 comment
Closed

Pass SDK options down as readonly #5248

lforst opened this issue Jun 10, 2022 · 1 comment

Comments

@lforst
Copy link
Contributor

lforst commented Jun 10, 2022

As discussed with @timfish in #5203 (comment), we were contemplating whether it would be a good idea for the SDK to pass options down as readonly. In that particular case it would have caught a bug, and might also do so in the future.

This is non-trivial of course, so we can just use this issue as grounds for discussion before actually starting to implement this.

(Just a random thought: This could be done as a hacktober PR)

@HazAT
Copy link
Member

HazAT commented Jan 26, 2023

I would not do it, there are certain edge cases where this hacky approach just fixes things for certain users.
Closing this avenue just makes everyone's life harder.

@HazAT HazAT closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants