Skip to content

[Replay] Make replay sample rates top-level config #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
Tracked by #6458
mydea opened this issue Nov 30, 2022 · 0 comments
Closed
2 tasks done
Tracked by #6458

[Replay] Make replay sample rates top-level config #6351

mydea opened this issue Nov 30, 2022 · 0 comments
Assignees
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement

Comments

@mydea
Copy link
Member

mydea commented Nov 30, 2022

Problem Statement

Currently, replay sample rates are configured directly in the integration:

Sentry.init({
  sampleRate: 0.5,
  tracesSampleRate: 0.1,
  profilesSampleRate: 0.25,
  integrations: [
    new Replay({
      sessionSampleRate: 0.1,
      errorSampleRate: 1.0
    })
});

This is inconsistent.

Solution Brainstorm

We want to move these options to the top level:

Sentry.init({
  sampleRate: 0.5,
  tracesSampleRate: 0.1,
  profilesSampleRate: 0.25,
  replaysSampleRate: 0.5,
  replaysOnErrorSampleRate: 1.0,
  integrations: [
    new Replay()
});

The goal is, for now, to deprecate the "old" options directly on Replay and remove them in a later release.

Steps

  • Add new top-level options
  • Deprecate configuration in integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement
Projects
None yet
Development

No branches or pull requests

1 participant