Skip to content

Test against Replay CDN bundles #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lms24 opened this issue Dec 22, 2022 · 2 comments · Fixed by #6770
Closed

Test against Replay CDN bundles #6613

Lms24 opened this issue Dec 22, 2022 · 2 comments · Fixed by #6770
Assignees
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Tests

Comments

@Lms24
Copy link
Member

Lms24 commented Dec 22, 2022

Problem Statement

We've had multiple broken CDN bundle releases because of how we minify bundles (#6600, #6493). We should think about testing against Replay's CDN bundles, similarly to how we test against our Browser CDN bundles.

Solution Brainstorm

Ideas:

  • [Probably easiest]: Adjust our browser Playwright tests to account for this
  • [Also worth considering]: Adjust E2E tests to also test against CDN bundles
@mydea
Copy link
Member

mydea commented Jan 13, 2023

I would consider this completed (for now) once we land #6611, wdyt?

@Lms24
Copy link
Member Author

Lms24 commented Jan 13, 2023

It's a good first step. I wanted to spend an hour or so to figure out if we can enable our new Replay integration tests to also test against the bundles. If it turns out to be a hard problem, I think we can table this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants