-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Dead Click False Positives on Vanguard? #8847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Updated vanguard to the latest SDK (rrweb 2.0) and still has issues with Dead Click detection: https://sentry.sentry.io/replays/e3ed86dccf7248d7ae99e17913551d20/?project=6301746&query=&referrer=%2Freplays%2F%3AreplaySlug%2F&statsPeriod=14d&yAxis=count%28%29&t=15 |
Hmm, I tried to replicate it e.g. here: https://sentry.sentry.io/replays/051c347bbd324602a011c95a83e49abc/?project=6301746&query=&referrer=%2Freplays%2F&statsPeriod=7d&t_main=dom&yAxis=count%28%29 but couldn't... I wonder if it is some race condition where the effect happens a tick before we register the click, or something like this... 🤔 |
We should update the SDK on vanguard and check if this is still happening? |
Updated today |
So, can we close this with our updates, or are there still major issues there we can see in vanguard? |
Ah! the PR bumping the SDK merged but didn't release it seems: https://github.com/getsentry/vanguard/runs/18861589123 Don't have access to debug in google cloud Wrote internally to get help |
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/browser
SDK Version
7.64.0
Framework Version
remix 7.64.0
Link to Sentry event
https://sentry.sentry.io/replays/fc4cf618be1e41e783fb419f33ba50af/
SDK Setup
normal
Steps to Reproduce
watch replay, see clicks had an affect on DOM, but dead clicks are in replay. can also replicate by going to vanguard and clicking on emojis / links
Expected Result
no dead clicks
Actual Result
dead clicks.
The text was updated successfully, but these errors were encountered: