Skip to content

Dead Click False Positives on Vanguard? #8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
JoshFerge opened this issue Aug 18, 2023 · 7 comments
Closed
3 tasks done

Dead Click False Positives on Vanguard? #8847

JoshFerge opened this issue Aug 18, 2023 · 7 comments
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@JoshFerge
Copy link
Member

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/browser

SDK Version

7.64.0

Framework Version

remix 7.64.0

Link to Sentry event

https://sentry.sentry.io/replays/fc4cf618be1e41e783fb419f33ba50af/

SDK Setup

normal

Steps to Reproduce

watch replay, see clicks had an affect on DOM, but dead clicks are in replay. can also replicate by going to vanguard and clicking on emojis / links

Expected Result

no dead clicks

Actual Result

dead clicks.

@github-actions github-actions bot added the Package: browser Issues related to the Sentry Browser SDK label Aug 18, 2023
@billyvg billyvg added Package: replay Issues related to the Sentry Replay SDK and removed Package: browser Issues related to the Sentry Browser SDK labels Aug 18, 2023
@bruno-garcia
Copy link
Member

@mydea
Copy link
Member

mydea commented Oct 5, 2023

Hmm, I tried to replicate it e.g. here: https://sentry.sentry.io/replays/051c347bbd324602a011c95a83e49abc/?project=6301746&query=&referrer=%2Freplays%2F&statsPeriod=7d&t_main=dom&yAxis=count%28%29 but couldn't... I wonder if it is some race condition where the effect happens a tick before we register the click, or something like this... 🤔

@mydea
Copy link
Member

mydea commented Nov 20, 2023

We should update the SDK on vanguard and check if this is still happening?

@bruno-garcia
Copy link
Member

Updated today

@mydea
Copy link
Member

mydea commented Nov 22, 2023

So, can we close this with our updates, or are there still major issues there we can see in vanguard?

@bruno-garcia
Copy link
Member

bruno-garcia commented Nov 22, 2023

Still happening: https://sentry.sentry.io/replays/a0df41f8fb764abaa8b9f096b5780227/?project=6301746&query=&referrer=%2Freplays%2F&statsPeriod=7d&yAxis=count%28%29

image

Ah! the PR bumping the SDK merged but didn't release it seems:

https://github.com/getsentry/vanguard/runs/18861589123

Don't have access to debug in google cloud

Wrote internally to get help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

No branches or pull requests

4 participants