From 57d25ff8fdb997880920fbbf99bcff16c079145b Mon Sep 17 00:00:00 2001 From: Onur Temizkan Date: Wed, 29 May 2024 17:39:34 -0400 Subject: [PATCH] fix(node): Skip capturing Hapi Boom responses v8. --- packages/node/src/integrations/tracing/hapi/index.ts | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/node/src/integrations/tracing/hapi/index.ts b/packages/node/src/integrations/tracing/hapi/index.ts index 70c6fd51664b..2d951142275e 100644 --- a/packages/node/src/integrations/tracing/hapi/index.ts +++ b/packages/node/src/integrations/tracing/hapi/index.ts @@ -15,7 +15,7 @@ import { logger } from '@sentry/utils'; import { DEBUG_BUILD } from '../../../debug-build'; import { generateInstrumentOnce } from '../../../otel/instrument'; import { ensureIsWrapped } from '../../../utils/ensureIsWrapped'; -import type { Boom, RequestEvent, ResponseObject, Server } from './types'; +import type { RequestEvent, Server } from './types'; const INTEGRATION_NAME = 'Hapi'; @@ -38,10 +38,6 @@ const _hapiIntegration = (() => { */ export const hapiIntegration = defineIntegration(_hapiIntegration); -function isBoomObject(response: ResponseObject | Boom): response is Boom { - return response && (response as Boom).isBoom !== undefined; -} - function isErrorEvent(event: RequestEvent): event is RequestEvent { return event && (event as RequestEvent).error !== undefined; } @@ -76,9 +72,7 @@ export const hapiErrorPlugin = { logger.warn('Isolation scope is still the default isolation scope - skipping setting transactionName'); } - if (request.response && isBoomObject(request.response)) { - sendErrorToSentry(request.response); - } else if (isErrorEvent(event)) { + if (isErrorEvent(event)) { sendErrorToSentry(event.error); } });