From d24303054f6479f78981903429a9bec034762a15 Mon Sep 17 00:00:00 2001
From: Abhijeet Prasad <aprasad@sentry.io>
Date: Tue, 25 Mar 2025 11:26:37 -0400
Subject: [PATCH 1/2] fix: Remove critical log severity level

---
 packages/browser/src/log.ts          | 32 ----------------------------
 packages/browser/test/log.test.ts    | 14 ------------
 packages/core/src/types-hoist/log.ts |  2 +-
 packages/node/src/log.ts             | 28 ------------------------
 packages/node/test/log.test.ts       |  9 --------
 5 files changed, 1 insertion(+), 84 deletions(-)

diff --git a/packages/browser/src/log.ts b/packages/browser/src/log.ts
index 69f8313a3378..23322c168a67 100644
--- a/packages/browser/src/log.ts
+++ b/packages/browser/src/log.ts
@@ -257,36 +257,4 @@ export function fatal(message: ParameterizedString, attributes?: Log['attributes
   captureLog('fatal', message, attributes);
 }
 
-/**
- * @summary Capture a log with the `critical` level. Requires `_experiments.enableLogs` to be enabled.
- *
- * @param message - The message to log.
- * @param attributes - Arbitrary structured data that stores information about the log - e.g., { security: 'breach', severity: 'high' }.
- *
- * @example
- *
- * ```
- * Sentry.logger.critical('Security breach detected', {
- *   type: 'unauthorized_access',
- *   user: '132123',
- *   endpoint: '/api/admin',
- *   timestamp: Date.now()
- * });
- * ```
- *
- * @example With template strings
- *
- * ```
- * Sentry.logger.critical(Sentry.logger.fmt`Multiple failed login attempts from user ${user}`, {
- *   attempts: 10,
- *   timeWindow: '5m',
- *   blocked: true,
- *   timestamp: Date.now()
- * });
- * ```
- */
-export function critical(message: ParameterizedString, attributes?: Log['attributes']): void {
-  captureLog('critical', message, attributes);
-}
-
 export { fmt } from '@sentry/core';
diff --git a/packages/browser/test/log.test.ts b/packages/browser/test/log.test.ts
index 9dec17fe01e0..201e609a5a0e 100644
--- a/packages/browser/test/log.test.ts
+++ b/packages/browser/test/log.test.ts
@@ -150,20 +150,6 @@ describe('Logger', () => {
         undefined,
       );
     });
-
-    it('should call _INTERNAL_captureLog with critical level', () => {
-      logger.critical('Test critical message', { key: 'value' });
-      expect(mockCaptureLog).toHaveBeenCalledWith(
-        {
-          level: 'critical',
-          message: 'Test critical message',
-          attributes: { key: 'value' },
-          severityNumber: undefined,
-        },
-        expect.any(Object),
-        undefined,
-      );
-    });
   });
 
   describe('Automatic flushing', () => {
diff --git a/packages/core/src/types-hoist/log.ts b/packages/core/src/types-hoist/log.ts
index 844c9223dbfd..35e30ce42b65 100644
--- a/packages/core/src/types-hoist/log.ts
+++ b/packages/core/src/types-hoist/log.ts
@@ -1,6 +1,6 @@
 import type { ParameterizedString } from './parameterize';
 
-export type LogSeverityLevel = 'trace' | 'debug' | 'info' | 'warn' | 'error' | 'fatal' | 'critical';
+export type LogSeverityLevel = 'trace' | 'debug' | 'info' | 'warn' | 'error' | 'fatal';
 
 export type SerializedLogAttributeValueType =
   | {
diff --git a/packages/node/src/log.ts b/packages/node/src/log.ts
index be5fc934351c..2523b0f77bf8 100644
--- a/packages/node/src/log.ts
+++ b/packages/node/src/log.ts
@@ -194,32 +194,4 @@ export function fatal(...args: CaptureLogArgs): void {
   captureLog('fatal', ...args);
 }
 
-/**
- * @summary Capture a log with the `critical` level. Requires `_experiments.enableLogs` to be enabled.
- *
- * You can either pass a message and attributes or a message template, params and attributes.
- *
- * @example
- *
- * ```
- * Sentry.logger.critical('Service health check failed', {
- *   service: 'payment-gateway',
- *   status: 'DOWN',
- *   lastHealthy: '2024-03-20T09:55:00Z'
- * });
- * ```
- *
- * @example With template strings
- *
- * ```
- * Sentry.logger.critical('Service %s is %s',
- *   ['payment-gateway', 'DOWN'],
- *   { lastHealthy: '2024-03-20T09:55:00Z' }
- * );
- * ```
- */
-export function critical(...args: CaptureLogArgs): void {
-  captureLog('critical', ...args);
-}
-
 export { fmt } from '@sentry/core';
diff --git a/packages/node/test/log.test.ts b/packages/node/test/log.test.ts
index 150e040f5ec5..ebb4019dd73b 100644
--- a/packages/node/test/log.test.ts
+++ b/packages/node/test/log.test.ts
@@ -88,15 +88,6 @@ describe('Node Logger', () => {
         attributes: { key: 'value' },
       });
     });
-
-    it('should call _INTERNAL_captureLog with critical level', () => {
-      nodeLogger.critical('Test critical message', { key: 'value' });
-      expect(mockCaptureLog).toHaveBeenCalledWith({
-        level: 'critical',
-        message: 'Test critical message',
-        attributes: { key: 'value' },
-      });
-    });
   });
 
   describe('Template string logging', () => {

From 0c2d95f65a822748b4ace78f79ffcd03a8098caa Mon Sep 17 00:00:00 2001
From: Abhijeet Prasad <aprasad@sentry.io>
Date: Tue, 25 Mar 2025 12:33:52 -0400
Subject: [PATCH 2/2] remove all critical methods

---
 packages/browser/test/index.test.ts | 1 -
 packages/browser/test/log.test.ts   | 1 -
 packages/node/test/log.test.ts      | 1 -
 3 files changed, 3 deletions(-)

diff --git a/packages/browser/test/index.test.ts b/packages/browser/test/index.test.ts
index f6f66184509f..ad4d47b1bf04 100644
--- a/packages/browser/test/index.test.ts
+++ b/packages/browser/test/index.test.ts
@@ -334,7 +334,6 @@ describe('SentryBrowser', () => {
       expect(logger.warn).toBeDefined();
       expect(logger.error).toBeDefined();
       expect(logger.fatal).toBeDefined();
-      expect(logger.critical).toBeDefined();
     });
   });
 });
diff --git a/packages/browser/test/log.test.ts b/packages/browser/test/log.test.ts
index 201e609a5a0e..9cddc3ecfc71 100644
--- a/packages/browser/test/log.test.ts
+++ b/packages/browser/test/log.test.ts
@@ -64,7 +64,6 @@ describe('Logger', () => {
       expect(logger.warn).toBeTypeOf('function');
       expect(logger.error).toBeTypeOf('function');
       expect(logger.fatal).toBeTypeOf('function');
-      expect(logger.critical).toBeTypeOf('function');
     });
 
     it('should call _INTERNAL_captureLog with trace level', () => {
diff --git a/packages/node/test/log.test.ts b/packages/node/test/log.test.ts
index ebb4019dd73b..bd2e051ddf50 100644
--- a/packages/node/test/log.test.ts
+++ b/packages/node/test/log.test.ts
@@ -32,7 +32,6 @@ describe('Node Logger', () => {
       expect(nodeLogger.warn).toBeTypeOf('function');
       expect(nodeLogger.error).toBeTypeOf('function');
       expect(nodeLogger.fatal).toBeTypeOf('function');
-      expect(nodeLogger.critical).toBeTypeOf('function');
     });
 
     it('should call _INTERNAL_captureLog with trace level', () => {