From 7923d1ba3d6e4557e51fa4969fe5589329f44f3f Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 1 Mar 2022 23:05:33 -0800 Subject: [PATCH 1/3] generate es6 tracing bundle --- packages/tracing/rollup.config.js | 55 +++++++++++++++++-------------- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/packages/tracing/rollup.config.js b/packages/tracing/rollup.config.js index f00c26a11ed3..f25846501c1e 100644 --- a/packages/tracing/rollup.config.js +++ b/packages/tracing/rollup.config.js @@ -1,30 +1,37 @@ import { makeBaseBundleConfig, makeLicensePlugin, terserPlugin } from '../../rollup.config'; +const builds = []; + const licensePlugin = makeLicensePlugin('@sentry/tracing & @sentry/browser'); -const baseBundleConfig = makeBaseBundleConfig({ - input: 'src/index.bundle.ts', - isAddOn: false, - jsVersion: 'es5', - outputFileBase: 'build/bundle.tracing', +['es5', 'es6'].forEach(jsVersion => { + const baseBundleConfig = makeBaseBundleConfig({ + input: 'src/index.bundle.ts', + isAddOn: false, + jsVersion, + outputFileBase: `build/bundle.tracing${jsVersion === 'es6' ? '.es6' : ''}`, + }); + + builds.push( + ...[ + { + ...baseBundleConfig, + output: { + ...baseBundleConfig.output, + file: `${baseBundleConfig.output.file}.js`, + }, + plugins: [...baseBundleConfig.plugins, licensePlugin], + }, + { + ...baseBundleConfig, + output: { + ...baseBundleConfig.output, + file: `${baseBundleConfig.output.file}.min.js`, + }, + plugins: [...baseBundleConfig.plugins, terserPlugin, licensePlugin], + }, + ], + ); }); -export default [ - // ES5 Browser Tracing Bundle - { - ...baseBundleConfig, - output: { - ...baseBundleConfig.output, - file: `${baseBundleConfig.output.file}.js`, - }, - plugins: [...baseBundleConfig.plugins, licensePlugin], - }, - { - ...baseBundleConfig, - output: { - ...baseBundleConfig.output, - file: `${baseBundleConfig.output.file}.min.js`, - }, - plugins: [...baseBundleConfig.plugins, terserPlugin, licensePlugin], - }, -]; +export default builds; From 28512030950c8331037e908c7a57b9744b0dc469 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Wed, 2 Mar 2022 07:00:35 -0800 Subject: [PATCH 2/3] test against es6 tracing bundle in playwright tests --- packages/integration-tests/utils/generatePlugin.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/integration-tests/utils/generatePlugin.ts b/packages/integration-tests/utils/generatePlugin.ts index 994b2a1a9125..8425dff7d006 100644 --- a/packages/integration-tests/utils/generatePlugin.ts +++ b/packages/integration-tests/utils/generatePlugin.ts @@ -29,9 +29,8 @@ const BUNDLE_PATHS: Record> = { esm: 'esm/index.js', bundle_es5: 'build/bundle.tracing.js', bundle_es5_min: 'build/bundle.tracing.min.js', - // `tracing` doesn't have an es6 build yet - bundle_es6: 'build/bundle.tracing.js', - bundle_es6_min: 'build/bundle.tracing.min.js', + bundle_es6: 'build/bundle.tracing.es6.js', + bundle_es6_min: 'build/bundle.tracing.es6.min.js', }, }; From 830ca68a846346468f82f699a707ea5b09cd5d87 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Wed, 2 Mar 2022 07:00:51 -0800 Subject: [PATCH 3/3] add es6 tracing bundle to size check --- .size-limit.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.size-limit.js b/.size-limit.js index e1e43c490ebf..060671b9e9b0 100644 --- a/.size-limit.js +++ b/.size-limit.js @@ -57,4 +57,10 @@ module.exports = [ gzip: true, limit: '100 KB', }, + { + name: '@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)', + path: 'packages/tracing/build/bundle.tracing.es6.min.js', + gzip: true, + limit: '100 KB', + }, ];