From 5c0c6694f60cd2505a741d87a12ba98696a890f5 Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Fri, 3 Jun 2022 09:11:25 +0100 Subject: [PATCH] Fix leaky headers --- packages/node/src/transports/http.ts | 10 ++++------ packages/node/test/transports/http.test.ts | 2 -- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/node/src/transports/http.ts b/packages/node/src/transports/http.ts index 34bcd786c1cf..52df8244461e 100644 --- a/packages/node/src/transports/http.ts +++ b/packages/node/src/transports/http.ts @@ -105,12 +105,10 @@ function createRequestExecutor( return new Promise((resolve, reject) => { let body = streamFromBody(request.body); - if (request.body.length > GZIP_THRESHOLD) { - options.headers = { - ...options.headers, - 'content-encoding': 'gzip', - }; + const headers: Record = { ...options.headers }; + if (request.body.length > GZIP_THRESHOLD) { + headers['content-encoding'] = 'gzip'; body = body.pipe(createGzip()); } @@ -118,7 +116,7 @@ function createRequestExecutor( { method: 'POST', agent, - headers: options.headers, + headers, hostname, path: `${pathname}${search}`, port, diff --git a/packages/node/test/transports/http.test.ts b/packages/node/test/transports/http.test.ts index 175924c7b9bd..e2e4af2352b9 100644 --- a/packages/node/test/transports/http.test.ts +++ b/packages/node/test/transports/http.test.ts @@ -42,8 +42,6 @@ function setupTestServer( const stream = req.headers['content-encoding'] === 'gzip' ? req.pipe(createGunzip({})) : req; - stream.on('error', () => {}); - stream.on('data', data => { chunks.push(data); });