diff --git a/packages/core/src/scope.ts b/packages/core/src/scope.ts index 722240f53a6d..44d2d6d61a18 100644 --- a/packages/core/src/scope.ts +++ b/packages/core/src/scope.ts @@ -411,6 +411,13 @@ export class Scope implements ScopeInterface { return this; } + /** + * @inheritDoc + */ + public getLastBreadcrumb(): Breadcrumb | undefined { + return this._breadcrumbs[this._breadcrumbs.length - 1]; + } + /** * @inheritDoc */ diff --git a/packages/replay/src/coreHandlers/handleScope.ts b/packages/replay/src/coreHandlers/handleScope.ts index 2e5a33609014..41cc4a6d4e02 100644 --- a/packages/replay/src/coreHandlers/handleScope.ts +++ b/packages/replay/src/coreHandlers/handleScope.ts @@ -5,10 +5,7 @@ import { createBreadcrumb } from '../util/createBreadcrumb'; let _LAST_BREADCRUMB: null | Breadcrumb = null; export function handleScope(scope: Scope): Breadcrumb | null { - // TODO: remove ignores here - // @ts-ignore using private val - // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access - const newBreadcrumb = scope._breadcrumbs[scope._breadcrumbs.length - 1]; + const newBreadcrumb = scope.getLastBreadcrumb(); // Listener can be called when breadcrumbs have not changed, so we store the // reference to the last crumb and only return a crumb if it has changed @@ -19,10 +16,9 @@ export function handleScope(scope: Scope): Breadcrumb | null { _LAST_BREADCRUMB = newBreadcrumb; if ( - // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access - ['fetch', 'xhr', 'sentry.event', 'sentry.transaction'].includes(newBreadcrumb.category) || - // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access - newBreadcrumb.category?.startsWith('ui.') + newBreadcrumb.category && + (['fetch', 'xhr', 'sentry.event', 'sentry.transaction'].includes(newBreadcrumb.category) || + newBreadcrumb.category.startsWith('ui.')) ) { return null; } diff --git a/packages/replay/test/unit/coreHandlers/handleScope.test.ts b/packages/replay/test/unit/coreHandlers/handleScope.test.ts index 459a3e53711f..dd650a685293 100644 --- a/packages/replay/test/unit/coreHandlers/handleScope.test.ts +++ b/packages/replay/test/unit/coreHandlers/handleScope.test.ts @@ -8,6 +8,9 @@ const mockHandleScope = HandleScope.handleScope as jest.MockedFunction