chore(internal): Add meaning full release name and dist to e2e tests builds (#3063)

Author: krystofwoldrich

.github/workflows/e2e.yml

@@ -265,6 +265,21 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
+      - name: Sentry Release
+        run: |
+          SENTRY_RELEASE_CANDIDATE=$(echo 'e2e/${{ github.ref }}' | perl -pe 's/\//-/g')
+          echo "SENTRY_RELEASE=$SENTRY_RELEASE_CANDIDATE" >> $GITHUB_ENV
+
+      - name: Sentry Dist
+        run: |
+          SENTRY_DIST_CANDIDATE=${{ matrix.rn-version }}-${{ matrix.rn-architecture }}-${{ matrix.platform }}-${{ matrix.build-type }}-${GITHUB_SHA:0:8}
+          echo "SENTRY_DIST=$SENTRY_DIST_CANDIDATE" >> $GITHUB_ENV
+
+      - name: Sentry Envs
+        run: |
+          echo "SENTRY_RELEASE=$SENTRY_RELEASE"
+          echo "SENTRY_DIST=$SENTRY_DIST"
+
       - uses: actions/setup-java@v3
         with:
           java-version: '11'

test/e2e/src/EndToEndTests.tsx

@@ -3,7 +3,6 @@ import * as Sentry from '@sentry/react-native';
 import * as React from 'react';
 import { Text, View } from 'react-native';
 
-import { SENTRY_INTERNAL_DSN } from './dsn';
 import { getTestProps } from './utils/getTestProps';
 
 export { getTestProps };
@@ -14,16 +13,14 @@ export { getTestProps };
 const EndToEndTestsScreen = (): JSX.Element => {
   const [eventId, setEventId] = React.useState<string | null | undefined>();
 
-  // !!! WARNING: Do not put Sentry.init inside React.useEffect like we do here. This is only for testing purposes.
+  // !!! WARNING: This is only for testing purposes.
   // We only do this to render the eventId onto the UI for end to end tests.
   React.useEffect(() => {
-    Sentry.init({
-      dsn: SENTRY_INTERNAL_DSN,
-      beforeSend: (e) => {
-        setEventId(e.event_id || null);
-        return e;
-      },
-    });
+    const client: Sentry.ReactNativeClient | undefined = Sentry.getCurrentHub().getClient();
+    client.getOptions().beforeSend = (e: Sentry.Event) => {
+      setEventId(e.event_id || null);
+      return e;
+    };
   }, []);
 
   return (
@@ -46,13 +43,6 @@ const EndToEndTestsScreen = (): JSX.Element => {
         }}>
         captureException
       </Text>
-      <Text
-        {...getTestProps('throwNewError')}
-        onPress={() => {
-          throw new Error('throw new error test');
-        }}>
-        throw new Error
-      </Text>
       <Text
         onPress={async () => {
           await Promise.reject(new Error('Unhandled Promise Rejection'));
@@ -67,12 +57,6 @@ const EndToEndTestsScreen = (): JSX.Element => {
         }}>
         close
       </Text>
-      <Text
-        onPress={() => {
-          Sentry.nativeCrash();
-        }}>
-        nativeCrash
-      </Text>
     </View>
   );
 };

test/e2e/src/dsn.ts

@@ -2,12 +2,15 @@
 
 const fs = require('fs');
 const path = require('path');
-const { argv } = require('process');
+const { argv, env } = require('process');
 
 const parseArgs = require('minimist');
 const { logger } = require('@sentry/utils');
 logger.enable();
 
+const SENTRY_RELEASE = env.SENTRY_RELEASE;
+const SENTRY_DIST = env.SENTRY_DIST;
+
 const args = parseArgs(argv.slice(2));
 if (!args.app) {
   throw new Error('Missing --app');
@@ -20,6 +23,8 @@ import * as Sentry from '@sentry/react-native';
 import { EndToEndTestsScreen } from 'sentry-react-native-e2e-tests';
 
 Sentry.init({
+  release: '${SENTRY_RELEASE}',
+  dist: '${SENTRY_DIST}',
   dsn: 'https://[email protected]/5428561',
 });
 `;

test/react-native/rn.patch.app.js

@@ -55,7 +55,7 @@ set -e
 WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
 REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
 
-/bin/sh -c "$WITH_ENVIRONMENT \\"../node_modules/@sentry/cli/bin/sentry-cli react-native xcode $REACT_NATIVE_XCODE\\""
+/bin/sh -c "$WITH_ENVIRONMENT \\"../node_modules/@sentry/cli/bin/sentry-cli react-native xcode --force-foreground $REACT_NATIVE_XCODE\\""
 
 /bin/sh ../node_modules/@sentry/react-native/scripts/collect-modules.sh
 `;