Skip to content

Commit 070a2b3

Browse files
ref: fix type errors in sentry.incidents (#72811)
fixes errors when BaseManager becomes typechecked <!-- Describe your PR here. -->
1 parent 79afa4b commit 070a2b3

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/sentry/incidents/endpoints/serializers/alert_rule.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,9 @@ def get_attrs(
175175
order_by=F("date_added").desc(),
176176
)
177177
)
178-
activations = alert_activations_ranked.filter(alert_rule__in=item_list, rank__lte=10)
178+
activations_qs = alert_activations_ranked.filter(alert_rule__in=item_list, rank__lte=10)
179179
activations_by_alert_rule_id = defaultdict(list)
180-
for activation in activations:
180+
for activation in activations_qs:
181181
activations_by_alert_rule_id[activation.alert_rule_id].append(activation)
182182

183183
alert_rule_projects = set()

src/sentry/incidents/endpoints/serializers/alert_rule_trigger.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ def serialize(self, obj, attrs, user, **kwargs):
5050
class DetailedAlertRuleTriggerSerializer(AlertRuleTriggerSerializer):
5151
def get_attrs(self, item_list, user, **kwargs):
5252
triggers = {item.id: item for item in item_list}
53-
result: DefaultDict[str, dict[str, list[str]]] = defaultdict(dict)
53+
result: dict[str, dict[str, list[str]]] = defaultdict(lambda: defaultdict(list))
5454
for trigger_id, project_slug in AlertRuleTriggerExclusion.objects.filter(
5555
alert_rule_trigger__in=item_list
5656
).values_list("alert_rule_trigger_id", "query_subscription__project__slug"):
57-
exclusions = result[triggers[trigger_id]].setdefault("excludedProjects", [])
58-
exclusions.append(project_slug)
57+
if project_slug is not None:
58+
result[triggers[trigger_id]]["excludedProjects"].append(project_slug)
5959
return result
6060

6161
def serialize(self, obj, attrs, user, **kwargs):

0 commit comments

Comments
 (0)