Skip to content

Commit 12daf60

Browse files
authored
feat: Allow to select v8 in Loader Script (#73835)
This adds a feature flag `organizations:js-sdj-loader-v8` that can be set that will add `8.x` to the selectable options for the Loader Script. Part of getsentry/sentry-javascript#12187
1 parent f3af800 commit 12daf60

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/sentry/features/temporary.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,8 @@ def register_temporary_features(manager: FeatureManager):
159159
# Enable the new issue stream search bar UI
160160
manager.add("organizations:issue-stream-search-query-builder", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
161161
manager.add("organizations:large-debug-files", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
162+
# Enable v8 support for the Loader Script
163+
manager.add("organizations:js-sdk-loader-v8", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
162164
# Enabled latest adopted release filter for issue alerts
163165
manager.add("organizations:latest-adopted-release-filter", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
164166
manager.add("organizations:mep-rollout-flag", OrganizationFeature, FeatureHandlerStrategy.REMOTE)

src/sentry/loader/browsersdkversion.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from packaging.version import Version
99

1010
import sentry
11+
from sentry import features
1112

1213
logger = logging.getLogger("sentry")
1314

@@ -37,8 +38,7 @@ def get_highest_browser_sdk_version(versions):
3738

3839

3940
def get_all_browser_sdk_version_versions():
40-
# todo: v8 add version
41-
return ["latest", "7.x", "6.x", "5.x", "4.x"]
41+
return ["latest", "8.x", "7.x", "6.x", "5.x", "4.x"]
4242

4343

4444
def get_all_browser_sdk_version_choices():
@@ -98,4 +98,9 @@ def get_default_sdk_version_for_project(project):
9898

9999

100100
def get_available_sdk_versions_for_project(project):
101-
return project.get_option("sentry:loader_available_sdk_versions")
101+
versions = project.get_option("sentry:loader_available_sdk_versions")
102+
103+
if features.has("organizations:js-sdk-loader-v8", project.organization, actor=None):
104+
return versions + ["8.x"]
105+
106+
return versions

0 commit comments

Comments
 (0)