Skip to content

Commit 20827cf

Browse files
committed
note about why we sort attachments
1 parent 17965b3 commit 20827cf

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

static/app/utils/replays/replayReader.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,8 @@ export default class ReplayReader {
135135
this._rrwebEvents.push(recordingEndFrame(replayRecord));
136136

137137
// Sort what needs sorting
138+
// TODO(replay): We could remove this sort call if useReplayData was more
139+
// careful about maintaining cursor order when calling setAttachments()
138140
this._rrwebEvents.sort((a, b) => a.timestamp - b.timestamp);
139141

140142
/*********************/

0 commit comments

Comments
 (0)