perf(issues): Reuse the group when fetching escalation forecasts (#127719)

Avoid reloading the group just to check `should_detect_escalation()`
when fetching an escalation forecast, both callers already have it. The
lookup was left over from when the check took an organization behind a
flag (#70443).

This runs for events on issues archived until escalating, roughly 30M
times a week in post_process at ~2ms p50, around 17 hours of db time a
week (ballpark) so again a pretty small change. [Example
trace](https://sentry.sentry.io/explore/traces/trace/d1138b8a7a8248d4b28a7f349b10225f/?node=span-91f7b1de6e7f52a1),
the `sentry_groupedmessage` select under `process_snoozes` is the one
that goes away.

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Author: 3 people

src/sentry/issues/endpoints/group_details.py

@@ -306,7 +306,7 @@ def get(self, request: Request, group: Group) -> Response[GroupDetailsResponse]:
                 data.update({"owners": owners})
 
             if "forecast" in expand:
-                fetched_forecast = EscalatingGroupForecast.fetch(group.project_id, group.id)
+                fetched_forecast = EscalatingGroupForecast.fetch(group)
                 if fetched_forecast:
                     fetched_forecast_dict = fetched_forecast.to_dict()
                     data.update(

src/sentry/issues/escalating/escalating.py

@@ -472,7 +472,7 @@ def is_escalating(group: Group) -> tuple[bool, int | None]:
             },
         )
 
-    forecast_today = EscalatingGroupForecast.fetch_todays_forecast(group.project.id, group.id)
+    forecast_today = EscalatingGroupForecast.fetch_todays_forecast(group)
     # Check if current event occurrence is greater than forecast for today's date
     if forecast_today and group_hourly_count > forecast_today:
         return True, forecast_today

src/sentry/issues/escalating/escalating_group_forecast.py

@@ -49,13 +49,7 @@ def save(self) -> None:
         )
 
     @classmethod
-    def _should_fetch_escalating(cls, group_id: int) -> bool:
-        group = Group.objects.get(id=group_id)
-
-        return group.issue_type.should_detect_escalation()
-
-    @classmethod
-    def fetch(cls, project_id: int, group_id: int) -> EscalatingGroupForecast | None:
+    def fetch(cls, group: Group) -> EscalatingGroupForecast | None:
         """
         Return the forecast from nodestore if it exists.
 
@@ -66,24 +60,24 @@ def fetch(cls, project_id: int, group_id: int) -> EscalatingGroupForecast | None
         """
         from sentry.issues.escalating.forecasts import generate_and_save_missing_forecasts
 
-        if not cls._should_fetch_escalating(group_id=group_id):
+        if not group.issue_type.should_detect_escalation():
             return None
 
-        results = nodestore.backend.get(cls.build_storage_identifier(project_id, group_id))
+        results = nodestore.backend.get(cls.build_storage_identifier(group.project_id, group.id))
         if results:
             return EscalatingGroupForecast.from_dict(results)
-        generate_and_save_missing_forecasts.delay(group_id=group_id)
+        generate_and_save_missing_forecasts.delay(group_id=group.id)
         return EscalatingGroupForecast(
-            project_id=project_id,
-            group_id=group_id,
+            project_id=group.project_id,
+            group_id=group.id,
             forecast=ONE_EVENT_FORECAST,
             date_added=datetime.now(),
         )
 
     @classmethod
-    def fetch_todays_forecast(cls, project_id: int, group_id: int) -> int | None:
+    def fetch_todays_forecast(cls, group: Group) -> int | None:
         date_now = datetime.now().date()
-        escalating_forecast = EscalatingGroupForecast.fetch(project_id, group_id)
+        escalating_forecast = EscalatingGroupForecast.fetch(group)
 
         if not escalating_forecast:
             return None

tests/sentry/issues/test_ignored.py

@@ -76,7 +76,7 @@ def test_archive_until_escalating_no_counts(
         assert not GroupSnooze.objects.filter(group=self.group).exists()
         assert status_details == {"ignoreUntilEscalating": True}
 
-        fetched_forecast = EscalatingGroupForecast.fetch(self.group.project.id, self.group.id)
+        fetched_forecast = EscalatingGroupForecast.fetch(self.group)
         assert fetched_forecast and fetched_forecast.forecast == ONE_EVENT_FORECAST
         assert mock_generate_and_save_missing_forecasts.call_count == 1
 
@@ -103,7 +103,7 @@ def test_archive_until_escalating_with_counts(
         assert not GroupSnooze.objects.filter(group=self.group).exists()
         assert status_details == {"ignoreUntilEscalating": True}
 
-        fetched_forecast = EscalatingGroupForecast.fetch(self.group.project.id, self.group.id)
+        fetched_forecast = EscalatingGroupForecast.fetch(self.group)
         assert fetched_forecast is not None
         assert fetched_forecast.project_id == self.group.project.id
         assert fetched_forecast.group_id == self.group.id

tests/sentry/tasks/test_weekly_escalating_forecast.py

@@ -48,7 +48,7 @@ def test_empty_escalating_forecast(
 
             run_escalating_forecast()
             group = group_list[0]
-            fetched_forecast = EscalatingGroupForecast.fetch(group.project.id, group.id)
+            fetched_forecast = EscalatingGroupForecast.fetch(group)
             assert fetched_forecast and fetched_forecast.forecast == ONE_EVENT_FORECAST
         assert mock_generate_and_save_missing_forecasts.call_count == 1
 
@@ -71,7 +71,7 @@ def test_empty_sd_escalating_forecast(
 
             run_escalating_forecast()
             group = group_list[0]
-            fetched_forecast = EscalatingGroupForecast.fetch(group.project.id, group.id)
+            fetched_forecast = EscalatingGroupForecast.fetch(group)
             assert fetched_forecast is None
         assert mock_generate_and_save_missing_forecasts.call_count == 0
 
@@ -91,9 +91,7 @@ def test_single_group_escalating_forecast(
 
             run_escalating_forecast()
             approximate_date_added = datetime.now(timezone.utc)
-            fetched_forecast = EscalatingGroupForecast.fetch(
-                group_list[0].project.id, group_list[0].id
-            )
+            fetched_forecast = EscalatingGroupForecast.fetch(group_list[0])
             assert fetched_forecast is not None
             assert fetched_forecast.project_id == group_list[0].project.id
             assert fetched_forecast.group_id == group_list[0].id
@@ -125,9 +123,7 @@ def test_single_sd_group_escalating_forecast(
 
             run_escalating_forecast()
 
-            fetched_forecast = EscalatingGroupForecast.fetch(
-                group_list[0].project.id, group_list[0].id
-            )
+            fetched_forecast = EscalatingGroupForecast.fetch(group_list[0])
 
             assert fetched_forecast is None
             self.assertNotIn("issue_forecasts.saved", record_mock.call_args)
@@ -149,9 +145,7 @@ def test_multiple_groups_escalating_forecast(
             run_escalating_forecast()
             approximate_date_added = datetime.now(timezone.utc)
             for i in range(len(group_list)):
-                fetched_forecast = EscalatingGroupForecast.fetch(
-                    group_list[i].project.id, group_list[i].id
-                )
+                fetched_forecast = EscalatingGroupForecast.fetch(group_list[i])
                 assert fetched_forecast is not None
                 assert fetched_forecast.project_id == group_list[i].project.id
                 assert fetched_forecast.group_id == group_list[i].id
@@ -183,9 +177,7 @@ def test_multiple_sd_groups_escalating_forecast(
 
             run_escalating_forecast()
             for i in range(len(group_list)):
-                fetched_forecast = EscalatingGroupForecast.fetch(
-                    group_list[i].project.id, group_list[i].id
-                )
+                fetched_forecast = EscalatingGroupForecast.fetch(group_list[i])
                 assert fetched_forecast is None
 
                 self.assertNotIn("issue_forecasts.saved", record_mock.call_args)
@@ -205,15 +197,11 @@ def test_update_group_escalating_forecast(
             )
 
             run_escalating_forecast()
-            first_fetched_forecast = EscalatingGroupForecast.fetch(
-                group_list[0].project.id, group_list[0].id
-            )
+            first_fetched_forecast = EscalatingGroupForecast.fetch(group_list[0])
 
             # Assert update when this is run twice
             run_escalating_forecast()
-            second_fetched_forecast = EscalatingGroupForecast.fetch(
-                group_list[0].project.id, group_list[0].id
-            )
+            second_fetched_forecast = EscalatingGroupForecast.fetch(group_list[0])
             assert first_fetched_forecast is not None
             assert second_fetched_forecast is not None
             assert first_fetched_forecast.date_added < second_fetched_forecast.date_added
@@ -239,15 +227,11 @@ def test_update_sd_group_escalating_forecast(
             )
 
             run_escalating_forecast()
-            first_fetched_forecast = EscalatingGroupForecast.fetch(
-                group_list[0].project.id, group_list[0].id
-            )
+            first_fetched_forecast = EscalatingGroupForecast.fetch(group_list[0])
 
             # Assert update when this is run twice
             run_escalating_forecast()
-            second_fetched_forecast = EscalatingGroupForecast.fetch(
-                group_list[0].project.id, group_list[0].id
-            )
+            second_fetched_forecast = EscalatingGroupForecast.fetch(group_list[0])
             assert first_fetched_forecast is None
             assert second_fetched_forecast is None