feat(trace-view): Removing trace-view-v1 flag (#94474)

This PR removes all usage of the 'trace-view-v1' flag from the FE. It
has been in full GA over the last couple quarters and we want the linked
functionality to be enabled by default in self hosted.

---------

Co-authored-by: Abdullah Khan <[email protected]>

Author: 2 people

static/app/components/events/eventStatisticalDetector/eventComparison/eventDisplay.spec.tsx

@@ -130,7 +130,12 @@ describe('eventDisplay', () => {
     MockApiClient.addMockResponse({
       url: `/organizations/org-slug/events/${mockProject.slug}:mock-id/`,
       method: 'GET',
-      body: EventFixture({tags: [{key: 'mock-tag', value: 'mock-value'}]}),
+      body: EventFixture({
+        tags: [{key: 'mock-tag', value: 'mock-value'}],
+        contexts: {
+          trace: {trace_id: 'trace-id'},
+        },
+      }),
     });
 
     render(
@@ -146,7 +151,10 @@ describe('eventDisplay', () => {
 
     expect(
       await screen.findByRole('button', {name: 'Full Event Details'})
-    ).toHaveAttribute('href', '/organizations/org-slug/insights/backend/project-slug:1/');
+    ).toHaveAttribute(
+      'href',
+      '/organizations/org-slug/traces/trace/trace-id/?statsPeriod=14d'
+    );
   });
 
   it('allows for pagination if there are more events loaded', async () => {

static/app/components/events/eventStatisticalDetector/eventComparison/eventDisplay.tsx

@@ -197,7 +197,6 @@ function EventDisplay({
   const traceSlug = eventData.contexts?.trace?.trace_id ?? '';
   const fullEventTarget = generateLinkToEventInTraceView({
     eventId: eventData.id,
-    projectSlug: project.slug,
     traceSlug,
     timestamp: eventData.endTimestamp,
     location,

static/app/components/events/interfaces/breadcrumbs/breadcrumb/data/default.tsx

@@ -96,14 +96,12 @@ function FormatMessage({
       return content;
     }
 
-    const projectSlug = maybeProject.slug;
     const description = transactionData ? (
       <Link
         to={generateLinkToEventInTraceView({
           eventId: message,
           timestamp: transactionData.timestamp,
           traceSlug: transactionData.trace,
-          projectSlug,
           organization,
           location: {...location, query: {...location.query, referrer: 'breadcrumbs'}},
         })}

static/app/components/events/interfaces/breadcrumbs/breadcrumbs.spec.tsx

@@ -22,7 +22,11 @@ describe('Breadcrumbs', () => {
 
     props = {
       organization: OrganizationFixture(),
-      event: EventFixture({entries: [], projectID: project.id}),
+      event: EventFixture({
+        entries: [],
+        projectID: project.id,
+        contexts: {trace: {trace_id: 'trace-id'}},
+      }),
       data: {
         values: [
           {
@@ -80,6 +84,7 @@ describe('Breadcrumbs', () => {
             title: '/settings/',
             'project.name': 'javascript',
             id: 'abcdabcdabcdabcdabcdabcdabcdabcd',
+            trace: 'trace-id',
           },
         ],
         meta: {},
@@ -209,7 +214,7 @@ describe('Breadcrumbs', () => {
 
       expect(screen.getByText('/settings/')).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project-slug:abcdabcdabcdabcdabcdabcdabcdabcd/?referrer=breadcrumbs'
+        '/organizations/org-slug/traces/trace/trace-id/?referrer=breadcrumbs&statsPeriod=14d'
       );
     });
   });

static/app/components/events/interfaces/performance/spanEvidenceKeyValueList.spec.tsx

@@ -70,7 +70,7 @@ describe('SpanEvidenceKeyValueList', () => {
       );
       expect(screen.getByRole('button', {name: 'View Full Trace'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project:a1/'
+        '/organizations/org-slug/traces/trace/8cbbc19c0f54447ab702f00263262726/?eventId=a1&statsPeriod=14d&timestamp=4'
       );
 
       expect(screen.getByRole('cell', {name: 'Parent Span'})).toBeInTheDocument();
@@ -144,7 +144,7 @@ describe('SpanEvidenceKeyValueList', () => {
       );
       expect(screen.getByRole('button', {name: 'View Full Trace'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project:a1/'
+        '/organizations/org-slug/traces/trace/8cbbc19c0f54447ab702f00263262726/?eventId=a1&statsPeriod=14d&timestamp=4'
       );
 
       expect(screen.getByRole('cell', {name: 'Parent Span'})).toBeInTheDocument();
@@ -227,7 +227,7 @@ describe('SpanEvidenceKeyValueList', () => {
       );
       expect(screen.getByRole('button', {name: 'View Full Trace'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project:a1/'
+        '/organizations/org-slug/traces/trace/8cbbc19c0f54447ab702f00263262726/?eventId=a1&statsPeriod=14d&timestamp=4'
       );
 
       expect(screen.getByRole('cell', {name: 'Parent Span'})).toBeInTheDocument();
@@ -320,7 +320,7 @@ describe('SpanEvidenceKeyValueList', () => {
       );
       expect(screen.getByRole('button', {name: 'View Full Trace'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project:a1/'
+        '/organizations/org-slug/traces/trace/8cbbc19c0f54447ab702f00263262726/?eventId=a1&statsPeriod=14d&timestamp=0.65'
       );
 
       expect(screen.getByRole('cell', {name: 'Starting Span'})).toBeInTheDocument();
@@ -472,7 +472,7 @@ describe('SpanEvidenceKeyValueList', () => {
       );
       expect(screen.getByRole('button', {name: 'View Full Trace'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project:a1/'
+        '/organizations/org-slug/traces/trace/8cbbc19c0f54447ab702f00263262726/?eventId=a1&statsPeriod=14d&timestamp=2100'
       );
 
       expect(screen.getByRole('cell', {name: 'Repeating Spans (2)'})).toBeInTheDocument();
@@ -632,7 +632,7 @@ describe('SpanEvidenceKeyValueList', () => {
       );
       expect(screen.getByRole('button', {name: 'View Full Trace'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project:a1/'
+        '/organizations/org-slug/traces/trace/8cbbc19c0f54447ab702f00263262726/?eventId=a1&statsPeriod=14d&timestamp=10100'
       );
 
       expect(screen.getByRole('cell', {name: 'Slow DB Query'})).toBeInTheDocument();
@@ -685,7 +685,7 @@ describe('SpanEvidenceKeyValueList', () => {
       );
       expect(screen.getByRole('button', {name: 'View Full Trace'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project:a1/'
+        '/organizations/org-slug/traces/trace/8cbbc19c0f54447ab702f00263262726/?eventId=a1&statsPeriod=14d&timestamp=3'
       );
 
       expect(screen.getByRole('cell', {name: 'Slow Resource Span'})).toBeInTheDocument();
@@ -749,7 +749,7 @@ describe('SpanEvidenceKeyValueList', () => {
       );
       expect(screen.getByRole('button', {name: 'View Full Trace'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project:a1/'
+        '/organizations/org-slug/traces/trace/8cbbc19c0f54447ab702f00263262726/?eventId=a1&statsPeriod=14d&timestamp=0.931'
       );
 
       expect(screen.getByRole('cell', {name: 'Slow Resource Span'})).toBeInTheDocument();
@@ -849,7 +849,7 @@ describe('SpanEvidenceKeyValueList', () => {
       );
       expect(screen.getByRole('button', {name: 'View Full Trace'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/insights/backend/project:a1/'
+        '/organizations/org-slug/traces/trace/8cbbc19c0f54447ab702f00263262726/?eventId=a1&statsPeriod=14d&timestamp=0.487'
       );
 
       expect(

static/app/components/events/interfaces/performance/spanEvidenceKeyValueList.tsx

@@ -545,7 +545,6 @@ const makeTransactionNameRow = (
 
   const eventDetailsLocation = generateLinkToEventInTraceView({
     traceSlug,
-    projectSlug: projectSlug ?? '',
     eventId: event.eventID,
     timestamp: event.endTimestamp ?? '',
     location,

static/app/components/events/interfaces/spans/aggregateSpanDetail.tsx

@@ -54,7 +54,6 @@ function renderSpanSamples(
       to={generateLinkToEventInTraceView({
         organization,
         traceSlug: trace,
-        projectSlug: project.slug,
         eventId: transaction,
         timestamp,
         location: {

static/app/components/events/profileEventEvidence.spec.tsx

@@ -60,7 +60,7 @@ describe('ProfileEventEvidence', function () {
 
     expect(screen.getByRole('button', {name: 'View Transaction'})).toHaveAttribute(
       'href',
-      '/organizations/org-slug/insights/backend/project-slug:transaction-id/?referrer=issue'
+      '/organizations/org-slug/traces/trace/trace-id/?referrer=issue&statsPeriod=14d'
     );
   });
 });

static/app/components/events/profileEventEvidence.tsx

@@ -33,7 +33,6 @@ export function ProfileEventEvidence({event, projectSlug}: ProfileEvidenceProps)
                   traceSlug,
                   timestamp: evidenceData.timestamp,
                   eventId: evidenceData.transactionId,
-                  projectSlug,
                   location: {...location, query: {...location.query, referrer: 'issue'}},
                   organization,
                 })}

static/app/components/profiling/continuousProfileHeader.tsx

@@ -15,14 +15,10 @@ import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
 
 interface ContinuousProfileHeader {
-  projectId: string;
   transaction: Event | null;
 }
 
-export function ContinuousProfileHeader({
-  transaction,
-  projectId,
-}: ContinuousProfileHeader) {
+export function ContinuousProfileHeader({transaction}: ContinuousProfileHeader) {
   const location = useLocation();
   const organization = useOrganization();
 
@@ -31,13 +27,10 @@ export function ContinuousProfileHeader({
     return [{type: 'landing', payload: {query: {}}}];
   }, []);
 
-  const projectSlug = projectId ?? '';
-
   const transactionTarget = transaction?.id
     ? generateLinkToEventInTraceView({
         timestamp: transaction.endTimestamp ?? '',
         eventId: transaction.id,
-        projectSlug,
         traceSlug: transaction.contexts?.trace?.trace_id ?? '',
         location,
         organization,