Skip to content

Commit 342c779

Browse files
ref: delete dead test (#73202)
<!-- Describe your PR here. -->
1 parent 8cd9de2 commit 342c779

File tree

2 files changed

+2
-44
lines changed

2 files changed

+2
-44
lines changed

tests/sentry/web/frontend/test_sentryapp_avatar.py

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -4,35 +4,13 @@
44

55
from sentry.models.avatars.sentry_app_avatar import SentryAppAvatar
66
from sentry.models.files.control_file import ControlFile
7-
from sentry.models.files.file import File
8-
from sentry.silo.base import SiloMode
97
from sentry.testutils.cases import APITestCase
10-
from sentry.testutils.silo import assume_test_silo_mode, control_silo_test
8+
from sentry.testutils.silo import control_silo_test
119
from sentry.web.frontend.generic import FOREVER_CACHE
1210

1311

1412
@control_silo_test
1513
class SentryAppAvatarTest(APITestCase):
16-
def test_headers(self):
17-
# We cannot read File from Control silo
18-
if SiloMode.get_current_mode() == SiloMode.CONTROL:
19-
return
20-
21-
sentry_app = self.create_sentry_app(name="Meow", organization=self.organization)
22-
with assume_test_silo_mode(SiloMode.REGION):
23-
photo = File.objects.create(name="test.png", type="avatar.file")
24-
photo.putfile(BytesIO(b"test"))
25-
avatar = SentryAppAvatar.objects.create(
26-
sentry_app=sentry_app, avatar_type=1, color=True, file_id=photo.id
27-
)
28-
url = reverse("sentry-app-avatar-url", kwargs={"avatar_id": avatar.ident})
29-
response = self.client.get(url)
30-
assert response.status_code == 200
31-
assert response["Cache-Control"] == FOREVER_CACHE
32-
assert response.get("Vary") == "Accept-Language, Cookie"
33-
assert response.get("Set-Cookie") is None
34-
assert response["Access-Control-Allow-Origin"]
35-
3614
def test_headers_control_file(self):
3715
sentry_app = self.create_sentry_app(name="Meow", organization=self.organization)
3816
photo = ControlFile.objects.create(name="test.png", type="avatar.file")

tests/sentry/web/frontend/test_user_avatar.py

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,33 +4,13 @@
44

55
from sentry.models.avatars.user_avatar import UserAvatar
66
from sentry.models.files.control_file import ControlFile
7-
from sentry.models.files.file import File
8-
from sentry.silo.base import SiloMode
97
from sentry.testutils.cases import TestCase
10-
from sentry.testutils.silo import assume_test_silo_mode, control_silo_test
8+
from sentry.testutils.silo import control_silo_test
119
from sentry.web.frontend.generic import FOREVER_CACHE
1210

1311

1412
@control_silo_test
1513
class UserAvatarTest(TestCase):
16-
def test_headers(self):
17-
# We cannot read File from Control silo
18-
if SiloMode.get_current_mode() == SiloMode.CONTROL:
19-
return
20-
21-
user = self.create_user(email="[email protected]")
22-
with assume_test_silo_mode(SiloMode.REGION):
23-
photo = File.objects.create(name="test.png", type="avatar.file")
24-
photo.putfile(BytesIO(b"test"))
25-
avatar = UserAvatar.objects.create(user=user, file_id=photo.id)
26-
url = reverse("sentry-user-avatar-url", kwargs={"avatar_id": avatar.ident})
27-
response = self.client.get(url)
28-
assert response.status_code == 200
29-
assert response["Cache-Control"] == FOREVER_CACHE
30-
assert response.get("Vary") is None
31-
assert response.get("Set-Cookie") is None
32-
assert response["Access-Control-Allow-Origin"]
33-
3414
def test_headers_control_file(self):
3515
user = self.create_user(email="[email protected]")
3616
photo = ControlFile.objects.create(name="test.png", type="avatar.file")

0 commit comments

Comments
 (0)