feat(scraps): add a lint rule flagging hand-rolled / manual tables (#127760)

Adds a `@sentry/scraps/no-manual-table` incubator rule that flags tables
built by hand instead of on `SimpleTable`. Existing violations are
enrolled as suppressions.

Closes DE-1728.

Author: JoshuaKGoldberg

oxlint.config.ts

@@ -21,10 +21,16 @@ const coreComponentFiles = [
 
 const testFiles = ['**/*.spec.{ts,js,tsx,jsx}', 'tests/js/**/*.{ts,js,tsx,jsx}'];
 
+const tableComponentFiles = [
+  'static/app/components/core/table/**/*.{ts,tsx}',
+  'static/app/components/tables/**/*.{ts,tsx}',
+];
+
 // incubator rules disallow new violations from being introduced
 // but suppress pre-existing violations on `master`
 export const incubator = defineConfig({
   rules: {
+    '@sentry/scraps/no-manual-table': 'error',
     '@sentry/scraps/prefer-primitives': 'error',
     '@sentry/scraps/prefer-container-responsive-props': 'error',
   },
@@ -33,6 +39,15 @@ export const incubator = defineConfig({
       files: coreComponentFiles,
       rules: {'@sentry/scraps/prefer-primitives': 'off'},
     },
+    {
+      files: [
+        ...tableComponentFiles,
+        ...testFiles,
+        '**/*.stories.{ts,tsx}',
+        'static/app/stories/**/*.{ts,tsx}',
+      ],
+      rules: {'@sentry/scraps/no-manual-table': 'off'},
+    },
     {
       files: testFiles,
       rules: fakeTimerRules,

static/app/oxlint-suppressions.json

@@ -104,6 +104,11 @@
       "count": 4
     }
   },
+  "components/checkInTimeline/checkInTooltip.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 3
+    }
+  },
   "components/clippedBox.spec.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 2
@@ -430,6 +435,11 @@
       "count": 1
     }
   },
+  "components/events/ourlogs/ourlogsSection.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 1
+    }
+  },
   "components/events/traceEventDataSection.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 1
@@ -1188,11 +1198,17 @@
     }
   },
   "components/resultGrid.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 8
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
   },
   "components/resultTable.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 1
+    },
     "@sentry/scraps/prefer-container-responsive-props": {
       "count": 1
     }
@@ -1350,6 +1366,11 @@
       "count": 2
     }
   },
+  "components/seer/repoTable/seerRepoTableHeader.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 2
+    }
+  },
   "components/seer/seerAutomationProjectList.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 2
@@ -1711,6 +1732,11 @@
       "count": 2
     }
   },
+  "views/admin/adminRelays.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 5
+    }
+  },
   "views/admin/adminWarnings.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 3
@@ -2146,6 +2172,9 @@
     }
   },
   "views/explore/logs/styles.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 1
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 5
     }
@@ -3190,6 +3219,9 @@
     }
   },
   "views/settings/account/notifications/notificationSettingsByEntity.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 1
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
@@ -3244,6 +3276,11 @@
       "count": 1
     }
   },
+  "views/settings/components/teamSelect/teamSelectForMember.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 1
+    }
+  },
   "views/settings/dynamicSampling/organizationSampleRateInput.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 7
@@ -3389,6 +3426,11 @@
       "count": 1
     }
   },
+  "views/settings/organizationTeams/teamMembers.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 1
+    }
+  },
   "views/settings/organizationTeams/teamMembersRow.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 1

static/gsAdmin/oxlint-suppressions.json

@@ -9,26 +9,82 @@
       "count": 13
     }
   },
+  "components/beacons/beaconCheckins.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 5
+    }
+  },
+  "components/beacons/relatedBeacons.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 6
+    }
+  },
   "components/changeBalanceAction.spec.tsx": {
     "@sentry/prefer-fake-timers": {
       "count": 1
     }
   },
+  "components/customerGrid.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 7
+    }
+  },
   "components/customerName.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
   },
+  "components/customers/customerAuditLog.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 5
+    }
+  },
+  "components/customers/customerCharges.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 5
+    }
+  },
+  "components/customers/customerHistory.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 5
+    }
+  },
   "components/customers/customerIntegrationDebugDetails.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 8
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
   },
+  "components/customers/customerInvoices.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 3
+    }
+  },
+  "components/customers/customerMembers.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 5
+    }
+  },
   "components/customers/customerOverview.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 6
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
   },
+  "components/customers/customerPolicies.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 3
+    }
+  },
+  "components/customers/customerProjects.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 4
+    }
+  },
   "components/customers/customerStats.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 1
@@ -40,6 +96,9 @@
     }
   },
   "components/eventUsers.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 4
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
@@ -54,6 +113,16 @@
       "count": 3
     }
   },
+  "components/policies/policyRevisions.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 5
+    }
+  },
+  "components/promoCodes/promoCodeClaimants.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 3
+    }
+  },
   "components/provisionSubscriptionAction.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 5
@@ -69,11 +138,39 @@
       "count": 1
     }
   },
+  "components/users/userEmailLog.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 9
+    }
+  },
+  "components/users/userEmails.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 4
+    }
+  },
+  "views/beacons.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 6
+    }
+  },
+  "views/billingAdmins.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 3
+    }
+  },
   "views/billingPlans.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 13
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 8
     }
   },
+  "views/broadcasts.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 5
+    }
+  },
   "views/customerContractDetails.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 2
@@ -84,21 +181,42 @@
       "count": 2
     }
   },
+  "views/docIntegrations.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 4
+    }
+  },
   "views/dynamicSamplingPanel.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
   },
   "views/giftRecurringCredits.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 10
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 4
     }
   },
+  "views/instanceLevelOAuth/instanceLevelOAuth.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 3
+    }
+  },
   "views/invoiceComparison.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 12
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
   },
+  "views/invoiceDetails.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 11
+    }
+  },
   "views/launchpadAdminPage.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 2
@@ -117,19 +235,62 @@
       "count": 1
     }
   },
+  "views/options.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 3
+    }
+  },
   "views/overview.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 9
+    },
     "@sentry/scraps/prefer-primitives": {
       "count": 2
     }
   },
+  "views/policies.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 3
+    }
+  },
   "views/privateAPIs.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
   },
+  "views/promoCodes.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 6
+    }
+  },
   "views/relocationCreate.tsx": {
     "@sentry/scraps/prefer-primitives": {
       "count": 1
     }
+  },
+  "views/relocationDetails.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 9
+    }
+  },
+  "views/relocations.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 7
+    }
+  },
+  "views/sentryApps.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 3
+    }
+  },
+  "views/sentryEmployees.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 8
+    }
+  },
+  "views/users.tsx": {
+    "@sentry/scraps/no-manual-table": {
+      "count": 5
+    }
   }
 }