Skip to content

Commit d98f198

Browse files
ref: match signatures of Manager post_save (#74954)
<!-- Describe your PR here. -->
1 parent 677c85f commit d98f198

File tree

11 files changed

+15
-11
lines changed

11 files changed

+15
-11
lines changed

src/sentry/db/models/manager/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ def uncache_object(self, instance_id: int) -> None:
482482
cache_key = self.__get_lookup_cache_key(**{pk_name: instance_id})
483483
cache.delete(cache_key, version=self.cache_version)
484484

485-
def post_save(self, instance: M, **kwargs: Any) -> None: # type: ignore[misc] # python/mypy#6178
485+
def post_save(self, *, instance: M, created: bool, **kwargs: object) -> None: # type: ignore[misc] # python/mypy#6178
486486
"""
487487
Triggered when a model bound to this manager is saved.
488488
"""

src/sentry/discover/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def __schedule_invalidate_project_config_transaction_commit(instance, trigger):
162162
if RuleType.BOOST_KEY_TRANSACTIONS_RULE.value in enabled_biases:
163163
schedule_invalidate_project_config(project_id=project.id, trigger=trigger)
164164

165-
def post_save(self, instance, **kwargs):
165+
def post_save(self, *, instance: TeamKeyTransaction, created: bool, **kwargs: object) -> None:
166166
# this hook may be called from model hooks during an
167167
# open transaction. In that case, wait until the current transaction has
168168
# been committed or rolled back to ensure we don't read stale data in the

src/sentry/models/options/organization_option.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def reload_cache(self, organization_id: int, update_reason: str) -> Mapping[str,
8181
self._option_cache[cache_key] = result
8282
return result
8383

84-
def post_save(self, instance: OrganizationOption, **kwargs: Any) -> None:
84+
def post_save(self, *, instance: OrganizationOption, created: bool, **kwargs: object) -> None:
8585
self.reload_cache(instance.organization_id, "organizationoption.post_save")
8686

8787
def post_delete(self, instance: OrganizationOption, **kwargs: Any) -> None:

src/sentry/models/options/project_option.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def reload_cache(self, project_id: int, update_reason: str) -> Mapping[str, Any]
146146
self._option_cache[cache_key] = result
147147
return result
148148

149-
def post_save(self, instance: ProjectOption, **kwargs: Any) -> None:
149+
def post_save(self, *, instance: ProjectOption, created: bool, **kwargs: object) -> None:
150150
self.reload_cache(instance.project_id, "projectoption.post_save")
151151

152152
def post_delete(self, instance: ProjectOption, **kwargs: Any) -> None:

src/sentry/models/options/project_template_option.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,9 @@ def reload_cache(self, project_template_id: int, update_reason: str) -> None:
8383
cache.set(cache_key, result)
8484
self._option_cache[cache_key] = result
8585

86-
def post_save(self, instance: ProjectTemplateOption, **kwargs: Any) -> None:
86+
def post_save(
87+
self, *, instance: ProjectTemplateOption, created: bool, **kwargs: object
88+
) -> None:
8789
self.reload_cache(instance.project_template_id, "projecttemplateoption.post_save")
8890

8991
def post_delete(self, instance: ProjectTemplateOption, **kwargs: Any) -> None:

src/sentry/models/options/user_option.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def get_all_values(
128128

129129
return self._option_cache.get(metakey, {})
130130

131-
def post_save(self, instance: UserOption, **kwargs: Any) -> None:
131+
def post_save(self, *, instance: UserOption, created: bool, **kwargs: object) -> None:
132132
self.get_all_values(
133133
instance.user, instance.project_id, instance.organization_id, force_reload=True
134134
)

src/sentry/models/projectkey.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class ProjectKeyStatus:
4242

4343

4444
class ProjectKeyManager(BaseManager["ProjectKey"]):
45-
def post_save(self, instance, **kwargs):
45+
def post_save(self, *, instance: ProjectKey, created: bool, **kwargs: object) -> None:
4646
schedule_invalidate_project_config(
4747
public_key=instance.public_key, trigger="projectkey.post_save"
4848
)

src/sentry/models/releaseprojectenvironment.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ def subscribe_project_to_alert_rule(
5656
activator=activator,
5757
)
5858

59-
def post_save(self, instance, created, **kwargs):
59+
def post_save(
60+
self, *, instance: ReleaseProjectEnvironment, created: bool, **kwargs: object
61+
) -> None:
6062
if created:
6163
release = instance.release
6264
project = instance.project

src/sentry/models/releases/release_project.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def subscribe_project_to_alert_rule(
5959
activator=release.version,
6060
)
6161

62-
def post_save(self, instance, created, **kwargs):
62+
def post_save(self, *, instance: ReleaseProject, created: bool, **kwargs: object) -> None:
6363
self._on_post(project=instance.project, trigger="releaseproject.post_save")
6464
if created:
6565
self.subscribe_project_to_alert_rule(

src/sentry/models/team.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def get_for_user(
123123

124124
return results
125125

126-
def post_save(self, instance, **kwargs):
126+
def post_save(self, *, instance: Team, created: bool, **kwargs: object) -> None:
127127
self.process_resource_change(instance, **kwargs)
128128

129129
def post_delete(self, instance, **kwargs):

tests/sentry/models/test_projectkey.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,6 @@ def test_key_saved_projconfig_invalidated(inv_proj_config, default_project):
193193

194194
key = ProjectKey.objects.get(project=default_project)
195195
manager = ProjectKeyManager()
196-
manager.post_save(key)
196+
manager.post_save(instance=key, created=False)
197197

198198
assert inv_proj_config.call_count == 1

0 commit comments

Comments
 (0)